| 12345678910111213141516171819202122232425 |
- From: Felix Fietkau <[email protected]>
- Date: Fri, 24 Mar 2023 13:04:17 +0100
- Subject: [PATCH] wifi: mac80211: fix invalid drv_sta_pre_rcu_remove calls for
- non-uploaded sta
- Avoid potential data corruption issues caused by uninitialized driver
- private data structures.
- Reported-by: Brian Coverstone <[email protected]>
- Fixes: 6a9d1b91f34d ("mac80211: add pre-RCU-sync sta removal driver operation")
- Signed-off-by: Felix Fietkau <[email protected]>
- ---
- --- a/net/mac80211/sta_info.c
- +++ b/net/mac80211/sta_info.c
- @@ -1041,7 +1041,8 @@ static int __must_check __sta_info_destr
- list_del_rcu(&sta->list);
- sta->removed = true;
-
- - drv_sta_pre_rcu_remove(local, sta->sdata, sta);
- + if (sta->uploaded)
- + drv_sta_pre_rcu_remove(local, sta->sdata, sta);
-
- if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN &&
- rcu_access_pointer(sdata->u.vlan.sta) == sta)
|
