553-tests-refactor-test_multi_ap.patch 2.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172
  1. From 0f5029ff41ef286aa7b3e4a3efd3f1a16be925e8 Mon Sep 17 00:00:00 2001
  2. From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]>
  3. Date: Wed, 9 Jan 2019 18:41:08 +0100
  4. Subject: [PATCH] tests: refactor test_multi_ap
  5. With just one additional argument, the run_multi_ap_association function
  6. can be used for all tests.
  7. While we're at it, also move it to the top of the file.
  8. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
  9. ---
  10. v4: new patch
  11. ---
  12. tests/hwsim/test_multi_ap.py | 30 +++++++++++-------------------
  13. 1 file changed, 11 insertions(+), 19 deletions(-)
  14. --- a/tests/hwsim/test_multi_ap.py
  15. +++ b/tests/hwsim/test_multi_ap.py
  16. @@ -6,6 +6,15 @@
  17. import hostapd
  18. +def run_multi_ap_association(dev, apdev, multi_ap, wait_connect=True):
  19. + params = hostapd.wpa2_params(ssid="multi-ap", passphrase="12345678")
  20. + if multi_ap:
  21. + params["multi_ap"] = str(multi_ap)
  22. + hapd = hostapd.add_ap(apdev[0], params)
  23. +
  24. + dev[0].connect("multi-ap", psk="12345678", scan_freq="2412",
  25. + multi_ap_backhaul_sta="1", wait_connect=wait_connect)
  26. +
  27. def test_multi_ap_association(dev, apdev):
  28. """Multi-AP association in backhaul BSS"""
  29. run_multi_ap_association(dev, apdev, 1)
  30. @@ -28,21 +37,9 @@ def test_multi_ap_association_shared_bss
  31. run_multi_ap_association(dev, apdev, 3)
  32. dev[1].connect("multi-ap", psk="12345678", scan_freq="2412")
  33. -def run_multi_ap_association(dev, apdev, multi_ap):
  34. - params = hostapd.wpa2_params(ssid="multi-ap", passphrase="12345678")
  35. - params["multi_ap"] = str(multi_ap)
  36. - hapd = hostapd.add_ap(apdev[0], params)
  37. -
  38. - dev[0].connect("multi-ap", psk="12345678", multi_ap_backhaul_sta="1",
  39. - scan_freq="2412")
  40. -
  41. def test_multi_ap_disabled_on_ap(dev, apdev):
  42. """Multi-AP association attempt when disabled on AP"""
  43. - params = hostapd.wpa2_params(ssid="multi-ap", passphrase="12345678")
  44. - hapd = hostapd.add_ap(apdev[0], params)
  45. -
  46. - dev[0].connect("multi-ap", psk="12345678", multi_ap_backhaul_sta="1",
  47. - scan_freq="2412", wait_connect=False)
  48. + run_multi_ap_association(dev, apdev, 0, wait_connect=False)
  49. ev = dev[0].wait_event([ "CTRL-EVENT-DISCONNECTED",
  50. "CTRL-EVENT-CONNECTED" ],
  51. timeout=5)
  52. @@ -54,12 +51,7 @@ def test_multi_ap_disabled_on_ap(dev, ap
  53. def test_multi_ap_fronthaul_on_ap(dev, apdev):
  54. """Multi-AP association attempt when only fronthaul BSS on AP"""
  55. - params = hostapd.wpa2_params(ssid="multi-ap", passphrase="12345678")
  56. - params["multi_ap"] = "2"
  57. - hapd = hostapd.add_ap(apdev[0], params)
  58. -
  59. - dev[0].connect("multi-ap", psk="12345678", multi_ap_backhaul_sta="1",
  60. - scan_freq="2412", wait_connect=False)
  61. + run_multi_ap_association(dev, apdev, 2, wait_connect=False)
  62. ev = dev[0].wait_event([ "CTRL-EVENT-DISCONNECTED",
  63. "CTRL-EVENT-CONNECTED",
  64. "CTRL-EVENT-ASSOC-REJECT" ],