123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657 |
- From 697c3892d825fb78f42ec8e53bed065dd728db3e Mon Sep 17 00:00:00 2001
- From: Daniel Golle <[email protected]>
- Date: Mon, 30 Jan 2023 02:04:57 +0000
- Subject: [PATCH] regmap: apply reg_base and reg_downshift for single register
- ops
- reg_base and reg_downshift currently don't have any effect if used with
- a regmap_bus or regmap_config which only offers single register
- operations (ie. reg_read, reg_write and optionally reg_update_bits).
- Fix that and take them into account also for regmap_bus with only
- reg_read and read_write operations by applying reg_base and
- reg_downshift in _regmap_bus_reg_write, _regmap_bus_reg_read.
- Also apply reg_base and reg_downshift in _regmap_update_bits, but only
- in case the operation is carried out with a reg_update_bits call
- defined in either regmap_bus or regmap_config.
- Fixes: 0074f3f2b1e43d ("regmap: allow a defined reg_base to be added to every address")
- Fixes: 86fc59ef818beb ("regmap: add configurable downshift for addresses")
- Signed-off-by: Daniel Golle <[email protected]>
- Tested-by: Colin Foster <[email protected]>
- Link: https://lore.kernel.org/r/[email protected]
- Signed-off-by: Mark Brown <[email protected]>
- ---
- drivers/base/regmap/regmap.c | 6 ++++++
- 1 file changed, 6 insertions(+)
- --- a/drivers/base/regmap/regmap.c
- +++ b/drivers/base/regmap/regmap.c
- @@ -1943,6 +1943,8 @@ static int _regmap_bus_reg_write(void *c
- {
- struct regmap *map = context;
-
- + reg += map->reg_base;
- + reg >>= map->format.reg_downshift;
- return map->bus->reg_write(map->bus_context, reg, val);
- }
-
- @@ -2715,6 +2717,8 @@ static int _regmap_bus_reg_read(void *co
- {
- struct regmap *map = context;
-
- + reg += map->reg_base;
- + reg >>= map->format.reg_downshift;
- return map->bus->reg_read(map->bus_context, reg, val);
- }
-
- @@ -3084,6 +3088,8 @@ static int _regmap_update_bits(struct re
- *change = false;
-
- if (regmap_volatile(map, reg) && map->reg_update_bits) {
- + reg += map->reg_base;
- + reg >>= map->format.reg_downshift;
- ret = map->reg_update_bits(map->bus_context, reg, mask, val);
- if (ret == 0 && change)
- *change = true;
|