352-v6.3-regmap-apply-reg_base-and-reg_downshift-for-single-r.patch 2.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657
  1. From 697c3892d825fb78f42ec8e53bed065dd728db3e Mon Sep 17 00:00:00 2001
  2. From: Daniel Golle <[email protected]>
  3. Date: Mon, 30 Jan 2023 02:04:57 +0000
  4. Subject: [PATCH] regmap: apply reg_base and reg_downshift for single register
  5. ops
  6. reg_base and reg_downshift currently don't have any effect if used with
  7. a regmap_bus or regmap_config which only offers single register
  8. operations (ie. reg_read, reg_write and optionally reg_update_bits).
  9. Fix that and take them into account also for regmap_bus with only
  10. reg_read and read_write operations by applying reg_base and
  11. reg_downshift in _regmap_bus_reg_write, _regmap_bus_reg_read.
  12. Also apply reg_base and reg_downshift in _regmap_update_bits, but only
  13. in case the operation is carried out with a reg_update_bits call
  14. defined in either regmap_bus or regmap_config.
  15. Fixes: 0074f3f2b1e43d ("regmap: allow a defined reg_base to be added to every address")
  16. Fixes: 86fc59ef818beb ("regmap: add configurable downshift for addresses")
  17. Signed-off-by: Daniel Golle <[email protected]>
  18. Tested-by: Colin Foster <[email protected]>
  19. Link: https://lore.kernel.org/r/[email protected]
  20. Signed-off-by: Mark Brown <[email protected]>
  21. ---
  22. drivers/base/regmap/regmap.c | 6 ++++++
  23. 1 file changed, 6 insertions(+)
  24. --- a/drivers/base/regmap/regmap.c
  25. +++ b/drivers/base/regmap/regmap.c
  26. @@ -1943,6 +1943,8 @@ static int _regmap_bus_reg_write(void *c
  27. {
  28. struct regmap *map = context;
  29. + reg += map->reg_base;
  30. + reg >>= map->format.reg_downshift;
  31. return map->bus->reg_write(map->bus_context, reg, val);
  32. }
  33. @@ -2715,6 +2717,8 @@ static int _regmap_bus_reg_read(void *co
  34. {
  35. struct regmap *map = context;
  36. + reg += map->reg_base;
  37. + reg >>= map->format.reg_downshift;
  38. return map->bus->reg_read(map->bus_context, reg, val);
  39. }
  40. @@ -3084,6 +3088,8 @@ static int _regmap_update_bits(struct re
  41. *change = false;
  42. if (regmap_volatile(map, reg) && map->reg_update_bits) {
  43. + reg += map->reg_base;
  44. + reg >>= map->format.reg_downshift;
  45. ret = map->reg_update_bits(map->bus_context, reg, mask, val);
  46. if (ret == 0 && change)
  47. *change = true;