170-media-atmel-atmel-isc-add-DMA-to-register-offsets.patch 4.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110
  1. From 7173e54070a9b530c8c16e0a507be71385133abd Mon Sep 17 00:00:00 2001
  2. From: Eugen Hristev <[email protected]>
  3. Date: Tue, 13 Apr 2021 12:57:12 +0200
  4. Subject: [PATCH 170/247] media: atmel: atmel-isc: add DMA to register offsets
  5. The DMA submodule is a part of the atmel-isc pipeline, and stands for
  6. Direct Memory Access. It acts like a master on the AXI bus of the SoC, and
  7. can directly write the RAM area with the pixel data from the ISC internal
  8. sram.
  9. Add dma to the reg offsets struct.
  10. This will allow different products to have a different reg offset for this
  11. particular module.
  12. Signed-off-by: Eugen Hristev <[email protected]>
  13. Signed-off-by: Hans Verkuil <[email protected]>
  14. Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  15. ---
  16. drivers/media/platform/atmel/atmel-isc-base.c | 19 ++++++++++++-------
  17. drivers/media/platform/atmel/atmel-isc-regs.h | 3 +++
  18. drivers/media/platform/atmel/atmel-isc.h | 2 ++
  19. .../media/platform/atmel/atmel-sama5d2-isc.c | 1 +
  20. 4 files changed, 18 insertions(+), 7 deletions(-)
  21. --- a/drivers/media/platform/atmel/atmel-isc-base.c
  22. +++ b/drivers/media/platform/atmel/atmel-isc-base.c
  23. @@ -601,16 +601,20 @@ static void isc_start_dma(struct isc_dev
  24. ISC_PFE_CFG0_COLEN | ISC_PFE_CFG0_ROWEN);
  25. addr0 = vb2_dma_contig_plane_dma_addr(&isc->cur_frm->vb.vb2_buf, 0);
  26. - regmap_write(regmap, ISC_DAD0, addr0);
  27. + regmap_write(regmap, ISC_DAD0 + isc->offsets.dma, addr0);
  28. switch (isc->config.fourcc) {
  29. case V4L2_PIX_FMT_YUV420:
  30. - regmap_write(regmap, ISC_DAD1, addr0 + (sizeimage * 2) / 3);
  31. - regmap_write(regmap, ISC_DAD2, addr0 + (sizeimage * 5) / 6);
  32. + regmap_write(regmap, ISC_DAD1 + isc->offsets.dma,
  33. + addr0 + (sizeimage * 2) / 3);
  34. + regmap_write(regmap, ISC_DAD2 + isc->offsets.dma,
  35. + addr0 + (sizeimage * 5) / 6);
  36. break;
  37. case V4L2_PIX_FMT_YUV422P:
  38. - regmap_write(regmap, ISC_DAD1, addr0 + sizeimage / 2);
  39. - regmap_write(regmap, ISC_DAD2, addr0 + (sizeimage * 3) / 4);
  40. + regmap_write(regmap, ISC_DAD1 + isc->offsets.dma,
  41. + addr0 + sizeimage / 2);
  42. + regmap_write(regmap, ISC_DAD2 + isc->offsets.dma,
  43. + addr0 + (sizeimage * 3) / 4);
  44. break;
  45. default:
  46. break;
  47. @@ -618,7 +622,8 @@ static void isc_start_dma(struct isc_dev
  48. dctrl_dview = isc->config.dctrl_dview;
  49. - regmap_write(regmap, ISC_DCTRL, dctrl_dview | ISC_DCTRL_IE_IS);
  50. + regmap_write(regmap, ISC_DCTRL + isc->offsets.dma,
  51. + dctrl_dview | ISC_DCTRL_IE_IS);
  52. spin_lock(&isc->awb_lock);
  53. regmap_write(regmap, ISC_CTRLEN, ISC_CTRL_CAPTURE);
  54. spin_unlock(&isc->awb_lock);
  55. @@ -731,7 +736,7 @@ static int isc_configure(struct isc_devi
  56. regmap_update_bits(regmap, ISC_RLP_CFG + isc->offsets.rlp,
  57. ISC_RLP_CFG_MODE_MASK, rlp_mode);
  58. - regmap_write(regmap, ISC_DCFG, dcfg);
  59. + regmap_write(regmap, ISC_DCFG + isc->offsets.dma, dcfg);
  60. /* Set the pipeline */
  61. isc_set_pipeline(isc, pipeline);
  62. --- a/drivers/media/platform/atmel/atmel-isc-regs.h
  63. +++ b/drivers/media/platform/atmel/atmel-isc-regs.h
  64. @@ -247,6 +247,9 @@
  65. #define ISC_HIS_CFG_RAR BIT(8)
  66. +/* Offset for DMA register specific to sama5d2 product */
  67. +#define ISC_SAMA5D2_DMA_OFFSET 0
  68. +
  69. /* DMA Configuration Register */
  70. #define ISC_DCFG 0x000003e0
  71. #define ISC_DCFG_IMODE_PACKED8 0x0
  72. --- a/drivers/media/platform/atmel/atmel-isc.h
  73. +++ b/drivers/media/platform/atmel/atmel-isc.h
  74. @@ -151,6 +151,7 @@ struct isc_ctrls {
  75. * @sub420: Offset for the SUB420 register
  76. * @rlp: Offset for the RLP register
  77. * @his: Offset for the HIS related registers
  78. + * @dma: Offset for the DMA related registers
  79. */
  80. struct isc_reg_offsets {
  81. u32 csc;
  82. @@ -159,6 +160,7 @@ struct isc_reg_offsets {
  83. u32 sub420;
  84. u32 rlp;
  85. u32 his;
  86. + u32 dma;
  87. };
  88. /*
  89. --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
  90. +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
  91. @@ -257,6 +257,7 @@ static int atmel_isc_probe(struct platfo
  92. isc->offsets.sub420 = ISC_SAMA5D2_SUB420_OFFSET;
  93. isc->offsets.rlp = ISC_SAMA5D2_RLP_OFFSET;
  94. isc->offsets.his = ISC_SAMA5D2_HIS_OFFSET;
  95. + isc->offsets.dma = ISC_SAMA5D2_DMA_OFFSET;
  96. /* sama5d2-isc - 8 bits per beat */
  97. isc->dcfg = ISC_DCFG_YMBSIZE_BEATS8 | ISC_DCFG_CMBSIZE_BEATS8;