| 12345678910111213141516171819202122232425262728293031323334353637383940 |
- From 0898ca67b86e14207d4feb3f3fea8b87cec5aab1 Mon Sep 17 00:00:00 2001
- From: Ansuel Smith <[email protected]>
- Date: Tue, 23 Nov 2021 16:44:46 +0100
- Subject: net: dsa: qca8k: fix warning in LAG feature
- Fix warning reported by bot.
- Make sure hash is init to 0 and fix wrong logic for hash_type in
- qca8k_lag_can_offload.
- Reported-by: kernel test robot <[email protected]>
- Fixes: def975307c01 ("net: dsa: qca8k: add LAG support")
- Signed-off-by: Ansuel Smith <[email protected]>
- Reviewed-by: Florian Fainelli <[email protected]>
- Link: https://lore.kernel.org/r/[email protected]
- Signed-off-by: Jakub Kicinski <[email protected]>
- ---
- drivers/net/dsa/qca8k.c | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
- --- a/drivers/net/dsa/qca8k.c
- +++ b/drivers/net/dsa/qca8k.c
- @@ -2232,7 +2232,7 @@ qca8k_lag_can_offload(struct dsa_switch
- if (info->tx_type != NETDEV_LAG_TX_TYPE_HASH)
- return false;
-
- - if (info->hash_type != NETDEV_LAG_HASH_L2 ||
- + if (info->hash_type != NETDEV_LAG_HASH_L2 &&
- info->hash_type != NETDEV_LAG_HASH_L23)
- return false;
-
- @@ -2246,8 +2246,8 @@ qca8k_lag_setup_hash(struct dsa_switch *
- {
- struct qca8k_priv *priv = ds->priv;
- bool unique_lag = true;
- + u32 hash = 0;
- int i, id;
- - u32 hash;
-
- id = dsa_lag_id(ds->dst, lag);
-
|
