| 1234567891011121314151617181920212223242526272829303132 |
- From cafbb70e148e7a4e318dcc1e36a96643815b6245 Mon Sep 17 00:00:00 2001
- From: Daniel Golle <[email protected]>
- Date: Mon, 3 Apr 2023 02:17:19 +0100
- Subject: [PATCH 03/48] net: dsa: mt7530: make some noise if register read
- fails
- Simply returning the negative error value instead of the read value
- doesn't seem like a good idea. Return 0 instead and add WARN_ON_ONCE(1)
- so this kind of error will not go unnoticed.
- Suggested-by: Andrew Lunn <[email protected]>
- Signed-off-by: Daniel Golle <[email protected]>
- Reviewed-by: Andrew Lunn <[email protected]>
- Signed-off-by: David S. Miller <[email protected]>
- ---
- drivers/net/dsa/mt7530.c | 3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
- --- a/drivers/net/dsa/mt7530.c
- +++ b/drivers/net/dsa/mt7530.c
- @@ -224,9 +224,10 @@ mt7530_mii_read(struct mt7530_priv *priv
- /* MT7530 uses 31 as the pseudo port */
- ret = bus->write(bus, 0x1f, 0x1f, page);
- if (ret < 0) {
- + WARN_ON_ONCE(1);
- dev_err(&bus->dev,
- "failed to read mt7530 register\n");
- - return ret;
- + return 0;
- }
-
- lo = bus->read(bus, 0x1f, r);
|
