| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051 |
- From 1a1a723d47c046d6c251651c9ade589040dafacf Mon Sep 17 00:00:00 2001
- From: "Russell King (Oracle)" <[email protected]>
- Date: Wed, 27 Sep 2023 13:13:56 +0100
- Subject: [PATCH 19/48] net: dsa: mt753x: remove mt753x_phylink_pcs_link_up()
- Remove the mt753x_phylink_pcs_link_up() function for two reasons:
- 1) priv->pcs[i].pcs.neg_mode is set true, meaning it doesn't take a
- MLO_AN_FIXED anymore, but one of PHYLINK_PCS_NEG_*. However, this
- is inconsequential due to...
- 2) priv->pcs[port].pcs.ops is always initialised to point at
- mt7530_pcs_ops, which does not have a pcs_link_up() member.
- So, let's remove mt753x_phylink_pcs_link_up() entirely.
- Signed-off-by: Russell King (Oracle) <[email protected]>
- Reviewed-by: Vladimir Oltean <[email protected]>
- Reviewed-by: Florian Fainelli <[email protected]>
- Link: https://lore.kernel.org/r/[email protected]
- Signed-off-by: Jakub Kicinski <[email protected]>
- ---
- drivers/net/dsa/mt7530.c | 11 -----------
- 1 file changed, 11 deletions(-)
- --- a/drivers/net/dsa/mt7530.c
- +++ b/drivers/net/dsa/mt7530.c
- @@ -2851,15 +2851,6 @@ static void mt753x_phylink_mac_link_down
- mt7530_clear(priv, MT7530_PMCR_P(port), PMCR_LINK_SETTINGS_MASK);
- }
-
- -static void mt753x_phylink_pcs_link_up(struct phylink_pcs *pcs,
- - unsigned int mode,
- - phy_interface_t interface,
- - int speed, int duplex)
- -{
- - if (pcs->ops->pcs_link_up)
- - pcs->ops->pcs_link_up(pcs, mode, interface, speed, duplex);
- -}
- -
- static void mt753x_phylink_mac_link_up(struct dsa_switch *ds, int port,
- unsigned int mode,
- phy_interface_t interface,
- @@ -2948,8 +2939,6 @@ mt7531_cpu_port_config(struct dsa_switch
- return ret;
- mt7530_write(priv, MT7530_PMCR_P(port),
- PMCR_CPU_PORT_SETTING(priv->id));
- - mt753x_phylink_pcs_link_up(&priv->pcs[port].pcs, MLO_AN_FIXED,
- - interface, speed, DUPLEX_FULL);
- mt753x_phylink_mac_link_up(ds, port, MLO_AN_FIXED, interface, NULL,
- speed, DUPLEX_FULL, true, true);
-
|
