| 123456789101112131415161718192021222324252627282930313233343536373839404142 |
- From 120581c81ad19704a9325505c83a82b7e760e96e Mon Sep 17 00:00:00 2001
- From: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= <[email protected]>
- Date: Mon, 22 Jan 2024 08:35:57 +0300
- Subject: [PATCH 28/48] net: dsa: mt7530: do not set priv->p5_interface on
- mt7530_setup_port5()
- MIME-Version: 1.0
- Content-Type: text/plain; charset=UTF-8
- Content-Transfer-Encoding: 8bit
- Running mt7530_setup_port5() from mt7530_setup() used to handle all cases
- of configuring port 5, including phylink.
- Setting priv->p5_interface under mt7530_setup_port5() makes sure that
- mt7530_setup_port5() from mt753x_phylink_mac_config() won't run.
- The commit ("net: dsa: mt7530: improve code path for setting up port 5")
- makes so that mt7530_setup_port5() from mt7530_setup() runs only on
- non-phylink cases.
- Get rid of unnecessarily setting priv->p5_interface under
- mt7530_setup_port5() as port 5 phylink configuration will be done by
- running mt7530_setup_port5() from mt753x_phylink_mac_config() now.
- Signed-off-by: Arınç ÜNAL <[email protected]>
- Reviewed-by: Vladimir Oltean <[email protected]>
- Link: https://lore.kernel.org/r/20240122-for-netnext-mt7530-improvements-1-v3-6-042401f2b279@arinc9.com
- Signed-off-by: Jakub Kicinski <[email protected]>
- ---
- drivers/net/dsa/mt7530.c | 2 --
- 1 file changed, 2 deletions(-)
- --- a/drivers/net/dsa/mt7530.c
- +++ b/drivers/net/dsa/mt7530.c
- @@ -971,8 +971,6 @@ static void mt7530_setup_port5(struct ds
- dev_dbg(ds->dev, "Setup P5, HWTRAP=0x%x, intf_sel=%s, phy-mode=%s\n",
- val, p5_intf_modes(priv->p5_intf_sel), phy_modes(interface));
-
- - priv->p5_interface = interface;
- -
- unlock_exit:
- mutex_unlock(&priv->reg_mutex);
- }
|
