| 1234567891011121314151617181920212223242526272829303132333435363738 |
- From 4440ce33074be6bd55d1a0c8b5f4b6d433ae2c74 Mon Sep 17 00:00:00 2001
- From: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= <[email protected]>
- Date: Tue, 6 Feb 2024 01:08:08 +0300
- Subject: [PATCH 36/48] net: dsa: mt7530: do not clear
- config->supported_interfaces
- MIME-Version: 1.0
- Content-Type: text/plain; charset=UTF-8
- Content-Transfer-Encoding: 8bit
- There's no need to clear the config->supported_interfaces bitmap before
- reporting the supported interfaces as all bits in the bitmap will already
- be initialized to zero when the phylink_config structure is allocated. The
- "config" pointer points to &dp->phylink_config, and "dp" is allocated by
- dsa_port_touch() with kzalloc(), so all its fields are filled with zeroes.
- There's no code that would change the bitmap beforehand. Remove it.
- Acked-by: Daniel Golle <[email protected]>
- Reviewed-by: Vladimir Oltean <[email protected]>
- Reviewed-by: Russell King (Oracle) <[email protected]>
- Signed-off-by: Arınç ÜNAL <[email protected]>
- Link: https://lore.kernel.org/r/20240206-for-netnext-mt7530-improvements-2-v5-7-d7d92a185cb1@arinc9.com
- Signed-off-by: Jakub Kicinski <[email protected]>
- ---
- drivers/net/dsa/mt7530.c | 2 --
- 1 file changed, 2 deletions(-)
- --- a/drivers/net/dsa/mt7530.c
- +++ b/drivers/net/dsa/mt7530.c
- @@ -2600,8 +2600,6 @@ static void mt7531_mac_port_get_caps(str
- static void mt7988_mac_port_get_caps(struct dsa_switch *ds, int port,
- struct phylink_config *config)
- {
- - phy_interface_zero(config->supported_interfaces);
- -
- switch (port) {
- /* Ports which are connected to switch PHYs. There is no MII pinout. */
- case 0 ... 3:
|
