093-3-v5.8-ipq806x-PCI-qcom-Add-missing-reset-for-ipq806x.patch 2.2 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162
  1. From ee367e2cdd2202b5714982739e684543cd2cee0e Mon Sep 17 00:00:00 2001
  2. From: Ansuel Smith <[email protected]>
  3. Date: Mon, 15 Jun 2020 23:06:00 +0200
  4. Subject: PCI: qcom: Add missing reset for ipq806x
  5. Add missing ext reset used by ipq8064 SoC in PCIe qcom driver.
  6. Link: https://lore.kernel.org/r/[email protected]
  7. Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver")
  8. Signed-off-by: Sham Muthayyan <[email protected]>
  9. Signed-off-by: Ansuel Smith <[email protected]>
  10. Signed-off-by: Lorenzo Pieralisi <[email protected]>
  11. Reviewed-by: Rob Herring <[email protected]>
  12. Reviewed-by: Philipp Zabel <[email protected]>
  13. Acked-by: Stanimir Varbanov <[email protected]>
  14. Cc: [email protected] # v4.5+
  15. ---
  16. drivers/pci/controller/dwc/pcie-qcom.c | 12 ++++++++++++
  17. 1 file changed, 12 insertions(+)
  18. --- a/drivers/pci/controller/dwc/pcie-qcom.c
  19. +++ b/drivers/pci/controller/dwc/pcie-qcom.c
  20. @@ -92,6 +92,7 @@ struct qcom_pcie_resources_2_1_0 {
  21. struct reset_control *ahb_reset;
  22. struct reset_control *por_reset;
  23. struct reset_control *phy_reset;
  24. + struct reset_control *ext_reset;
  25. struct regulator_bulk_data supplies[QCOM_PCIE_2_1_0_MAX_SUPPLY];
  26. };
  27. @@ -261,6 +262,10 @@ static int qcom_pcie_get_resources_2_1_0
  28. if (IS_ERR(res->por_reset))
  29. return PTR_ERR(res->por_reset);
  30. + res->ext_reset = devm_reset_control_get_optional_exclusive(dev, "ext");
  31. + if (IS_ERR(res->ext_reset))
  32. + return PTR_ERR(res->ext_reset);
  33. +
  34. res->phy_reset = devm_reset_control_get_exclusive(dev, "phy");
  35. return PTR_ERR_OR_ZERO(res->phy_reset);
  36. }
  37. @@ -274,6 +279,7 @@ static void qcom_pcie_deinit_2_1_0(struc
  38. reset_control_assert(res->axi_reset);
  39. reset_control_assert(res->ahb_reset);
  40. reset_control_assert(res->por_reset);
  41. + reset_control_assert(res->ext_reset);
  42. reset_control_assert(res->phy_reset);
  43. clk_disable_unprepare(res->iface_clk);
  44. clk_disable_unprepare(res->core_clk);
  45. @@ -332,6 +338,12 @@ static int qcom_pcie_init_2_1_0(struct q
  46. goto err_deassert_ahb;
  47. }
  48. + ret = reset_control_deassert(res->ext_reset);
  49. + if (ret) {
  50. + dev_err(dev, "cannot deassert ext reset\n");
  51. + goto err_deassert_ahb;
  52. + }
  53. +
  54. /* enable PCIe clocks and resets */
  55. val = readl(pcie->parf + PCIE20_PARF_PHY_CTRL);
  56. val &= ~BIT(0);