| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162 |
- From ee367e2cdd2202b5714982739e684543cd2cee0e Mon Sep 17 00:00:00 2001
- From: Ansuel Smith <[email protected]>
- Date: Mon, 15 Jun 2020 23:06:00 +0200
- Subject: PCI: qcom: Add missing reset for ipq806x
- Add missing ext reset used by ipq8064 SoC in PCIe qcom driver.
- Link: https://lore.kernel.org/r/[email protected]
- Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver")
- Signed-off-by: Sham Muthayyan <[email protected]>
- Signed-off-by: Ansuel Smith <[email protected]>
- Signed-off-by: Lorenzo Pieralisi <[email protected]>
- Reviewed-by: Rob Herring <[email protected]>
- Reviewed-by: Philipp Zabel <[email protected]>
- Acked-by: Stanimir Varbanov <[email protected]>
- Cc: [email protected] # v4.5+
- ---
- drivers/pci/controller/dwc/pcie-qcom.c | 12 ++++++++++++
- 1 file changed, 12 insertions(+)
- --- a/drivers/pci/controller/dwc/pcie-qcom.c
- +++ b/drivers/pci/controller/dwc/pcie-qcom.c
- @@ -92,6 +92,7 @@ struct qcom_pcie_resources_2_1_0 {
- struct reset_control *ahb_reset;
- struct reset_control *por_reset;
- struct reset_control *phy_reset;
- + struct reset_control *ext_reset;
- struct regulator_bulk_data supplies[QCOM_PCIE_2_1_0_MAX_SUPPLY];
- };
-
- @@ -261,6 +262,10 @@ static int qcom_pcie_get_resources_2_1_0
- if (IS_ERR(res->por_reset))
- return PTR_ERR(res->por_reset);
-
- + res->ext_reset = devm_reset_control_get_optional_exclusive(dev, "ext");
- + if (IS_ERR(res->ext_reset))
- + return PTR_ERR(res->ext_reset);
- +
- res->phy_reset = devm_reset_control_get_exclusive(dev, "phy");
- return PTR_ERR_OR_ZERO(res->phy_reset);
- }
- @@ -274,6 +279,7 @@ static void qcom_pcie_deinit_2_1_0(struc
- reset_control_assert(res->axi_reset);
- reset_control_assert(res->ahb_reset);
- reset_control_assert(res->por_reset);
- + reset_control_assert(res->ext_reset);
- reset_control_assert(res->phy_reset);
- clk_disable_unprepare(res->iface_clk);
- clk_disable_unprepare(res->core_clk);
- @@ -332,6 +338,12 @@ static int qcom_pcie_init_2_1_0(struct q
- goto err_deassert_ahb;
- }
-
- + ret = reset_control_deassert(res->ext_reset);
- + if (ret) {
- + dev_err(dev, "cannot deassert ext reset\n");
- + goto err_deassert_ahb;
- + }
- +
- /* enable PCIe clocks and resets */
- val = readl(pcie->parf + PCIE20_PARF_PHY_CTRL);
- val &= ~BIT(0);
|