| 123456789101112131415161718192021222324252627282930 |
- From fb1bbb5b63e4e3c788a978724749ced57d208054 Mon Sep 17 00:00:00 2001
- From: Minjie Du <[email protected]>
- Date: Thu, 21 Sep 2023 17:10:50 +0800
- Subject: [PATCH 38/42] thermal/drivers/mediatek/lvts_thermal: Fix error check
- in lvts_debugfs_init()
- debugfs_create_dir() function returns an error value embedded in
- the pointer (PTR_ERR). Evaluate the return value using IS_ERR
- rather than checking for NULL.
- Signed-off-by: Minjie Du <[email protected]>
- Reviewed-by: Alexandre Mergnat <[email protected]>
- Reviewed-by: Chen-Yu Tsai <[email protected]>
- Signed-off-by: Daniel Lezcano <[email protected]>
- Link: https://lore.kernel.org/r/[email protected]
- ---
- drivers/thermal/mediatek/lvts_thermal.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
- --- a/drivers/thermal/mediatek/lvts_thermal.c
- +++ b/drivers/thermal/mediatek/lvts_thermal.c
- @@ -219,7 +219,7 @@ static int lvts_debugfs_init(struct devi
-
- sprintf(name, "controller%d", i);
- dentry = debugfs_create_dir(name, lvts_td->dom_dentry);
- - if (!dentry)
- + if (IS_ERR(dentry))
- continue;
-
- regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL);
|