| 123456789101112131415161718192021222324252627282930313233343536373839 |
- Subject: Bug#284382: ppp: linkpidfile is not created upon detachment
- From: <[email protected]>
- Package: ppp
- Version: 2.4.2+20040428-2
- Severity: wishlist
- When pppd detaches from the parent normally, that is, without nodetach
- or updetach set, the linkpidfile is not created even when linkname is
- set.
- This is because the create_linkpidfile call in detach() is only made
- if the linkpidfile is filled in. However, linkpidfile is never filled
- in until create_linkpidfile has been called.
- IMHO the call should be made uncondtionally in detach() since
- create_linkpidfile does its own check on linkname anyway.
- Please note that the version of pppd in woody always wrote the
- linkpidfile after detaching. It did so in main() however. That
- call has now been removed which is why I'm seeing this problem.
- [...]
- --
- Index: ppp-2.4.3/pppd/main.c
- ===================================================================
- --- ppp-2.4.3.orig/pppd/main.c 2007-06-04 13:22:09.004486392 +0200
- +++ ppp-2.4.3/pppd/main.c 2007-06-04 13:22:10.548251704 +0200
- @@ -768,8 +768,7 @@
- /* update pid files if they have been written already */
- if (pidfilename[0])
- create_pidfile(pid);
- - if (linkpidfile[0])
- - create_linkpidfile(pid);
- + create_linkpidfile(pid);
- exit(0); /* parent dies */
- }
- setsid();
|
