300-cfg80211-support-immediate-reconnect-request-hint.patch 10 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301
  1. From: Johannes Berg <[email protected]>
  2. Date: Sun, 6 Dec 2020 14:54:42 +0200
  3. Subject: [PATCH] cfg80211: support immediate reconnect request hint
  4. There are cases where it's necessary to disconnect, but an
  5. immediate reconnection is desired. Support a hint to userspace
  6. that this is the case, by including a new attribute in the
  7. deauth or disassoc event.
  8. Signed-off-by: Luca Coelho <[email protected]>
  9. Link: https://lore.kernel.org/r/iwlwifi.20201206145305.58d33941fb9d.I0e7168c205c7949529c8e3b86f3c9b12c01a7017@changeid
  10. Signed-off-by: Johannes Berg <[email protected]>
  11. ---
  12. --- a/include/net/cfg80211.h
  13. +++ b/include/net/cfg80211.h
  14. @@ -6410,13 +6410,15 @@ void cfg80211_abandon_assoc(struct net_d
  15. * @dev: network device
  16. * @buf: 802.11 frame (header + body)
  17. * @len: length of the frame data
  18. + * @reconnect: immediate reconnect is desired (include the nl80211 attribute)
  19. *
  20. * This function is called whenever deauthentication has been processed in
  21. * station mode. This includes both received deauthentication frames and
  22. * locally generated ones. This function may sleep. The caller must hold the
  23. * corresponding wdev's mutex.
  24. */
  25. -void cfg80211_tx_mlme_mgmt(struct net_device *dev, const u8 *buf, size_t len);
  26. +void cfg80211_tx_mlme_mgmt(struct net_device *dev, const u8 *buf, size_t len,
  27. + bool reconnect);
  28. /**
  29. * cfg80211_rx_unprot_mlme_mgmt - notification of unprotected mlme mgmt frame
  30. --- a/include/uapi/linux/nl80211.h
  31. +++ b/include/uapi/linux/nl80211.h
  32. @@ -2527,6 +2527,10 @@ enum nl80211_commands {
  33. * override mask. Used with NL80211_ATTR_S1G_CAPABILITY in
  34. * NL80211_CMD_ASSOCIATE or NL80211_CMD_CONNECT.
  35. *
  36. + * @NL80211_ATTR_RECONNECT_REQUESTED: flag attribute, used with deauth and
  37. + * disassoc events to indicate that an immediate reconnect to the AP
  38. + * is desired.
  39. + *
  40. * @NUM_NL80211_ATTR: total number of nl80211_attrs available
  41. * @NL80211_ATTR_MAX: highest attribute number currently defined
  42. * @__NL80211_ATTR_AFTER_LAST: internal use
  43. @@ -3016,6 +3020,8 @@ enum nl80211_attrs {
  44. NL80211_ATTR_S1G_CAPABILITY,
  45. NL80211_ATTR_S1G_CAPABILITY_MASK,
  46. + NL80211_ATTR_RECONNECT_REQUESTED,
  47. +
  48. /* add attributes here, update the policy in nl80211.c */
  49. __NL80211_ATTR_AFTER_LAST,
  50. --- a/net/mac80211/mlme.c
  51. +++ b/net/mac80211/mlme.c
  52. @@ -2729,7 +2729,7 @@ static void ieee80211_report_disconnect(
  53. };
  54. if (tx)
  55. - cfg80211_tx_mlme_mgmt(sdata->dev, buf, len);
  56. + cfg80211_tx_mlme_mgmt(sdata->dev, buf, len, false);
  57. else
  58. cfg80211_rx_mlme_mgmt(sdata->dev, buf, len);
  59. @@ -4716,7 +4716,8 @@ void ieee80211_mgd_quiesce(struct ieee80
  60. if (ifmgd->auth_data)
  61. ieee80211_destroy_auth_data(sdata, false);
  62. cfg80211_tx_mlme_mgmt(sdata->dev, frame_buf,
  63. - IEEE80211_DEAUTH_FRAME_LEN);
  64. + IEEE80211_DEAUTH_FRAME_LEN,
  65. + false);
  66. }
  67. /* This is a bit of a hack - we should find a better and more generic
  68. --- a/net/wireless/mlme.c
  69. +++ b/net/wireless/mlme.c
  70. @@ -4,7 +4,7 @@
  71. *
  72. * Copyright (c) 2009, Jouni Malinen <[email protected]>
  73. * Copyright (c) 2015 Intel Deutschland GmbH
  74. - * Copyright (C) 2019 Intel Corporation
  75. + * Copyright (C) 2019-2020 Intel Corporation
  76. */
  77. #include <linux/kernel.h>
  78. @@ -81,7 +81,8 @@ static void cfg80211_process_auth(struct
  79. }
  80. static void cfg80211_process_deauth(struct wireless_dev *wdev,
  81. - const u8 *buf, size_t len)
  82. + const u8 *buf, size_t len,
  83. + bool reconnect)
  84. {
  85. struct cfg80211_registered_device *rdev = wiphy_to_rdev(wdev->wiphy);
  86. struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)buf;
  87. @@ -89,7 +90,7 @@ static void cfg80211_process_deauth(stru
  88. u16 reason_code = le16_to_cpu(mgmt->u.deauth.reason_code);
  89. bool from_ap = !ether_addr_equal(mgmt->sa, wdev->netdev->dev_addr);
  90. - nl80211_send_deauth(rdev, wdev->netdev, buf, len, GFP_KERNEL);
  91. + nl80211_send_deauth(rdev, wdev->netdev, buf, len, reconnect, GFP_KERNEL);
  92. if (!wdev->current_bss ||
  93. !ether_addr_equal(wdev->current_bss->pub.bssid, bssid))
  94. @@ -100,7 +101,8 @@ static void cfg80211_process_deauth(stru
  95. }
  96. static void cfg80211_process_disassoc(struct wireless_dev *wdev,
  97. - const u8 *buf, size_t len)
  98. + const u8 *buf, size_t len,
  99. + bool reconnect)
  100. {
  101. struct cfg80211_registered_device *rdev = wiphy_to_rdev(wdev->wiphy);
  102. struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)buf;
  103. @@ -108,7 +110,8 @@ static void cfg80211_process_disassoc(st
  104. u16 reason_code = le16_to_cpu(mgmt->u.disassoc.reason_code);
  105. bool from_ap = !ether_addr_equal(mgmt->sa, wdev->netdev->dev_addr);
  106. - nl80211_send_disassoc(rdev, wdev->netdev, buf, len, GFP_KERNEL);
  107. + nl80211_send_disassoc(rdev, wdev->netdev, buf, len, reconnect,
  108. + GFP_KERNEL);
  109. if (WARN_ON(!wdev->current_bss ||
  110. !ether_addr_equal(wdev->current_bss->pub.bssid, bssid)))
  111. @@ -133,9 +136,9 @@ void cfg80211_rx_mlme_mgmt(struct net_de
  112. if (ieee80211_is_auth(mgmt->frame_control))
  113. cfg80211_process_auth(wdev, buf, len);
  114. else if (ieee80211_is_deauth(mgmt->frame_control))
  115. - cfg80211_process_deauth(wdev, buf, len);
  116. + cfg80211_process_deauth(wdev, buf, len, false);
  117. else if (ieee80211_is_disassoc(mgmt->frame_control))
  118. - cfg80211_process_disassoc(wdev, buf, len);
  119. + cfg80211_process_disassoc(wdev, buf, len, false);
  120. }
  121. EXPORT_SYMBOL(cfg80211_rx_mlme_mgmt);
  122. @@ -180,22 +183,23 @@ void cfg80211_abandon_assoc(struct net_d
  123. }
  124. EXPORT_SYMBOL(cfg80211_abandon_assoc);
  125. -void cfg80211_tx_mlme_mgmt(struct net_device *dev, const u8 *buf, size_t len)
  126. +void cfg80211_tx_mlme_mgmt(struct net_device *dev, const u8 *buf, size_t len,
  127. + bool reconnect)
  128. {
  129. struct wireless_dev *wdev = dev->ieee80211_ptr;
  130. struct ieee80211_mgmt *mgmt = (void *)buf;
  131. ASSERT_WDEV_LOCK(wdev);
  132. - trace_cfg80211_tx_mlme_mgmt(dev, buf, len);
  133. + trace_cfg80211_tx_mlme_mgmt(dev, buf, len, reconnect);
  134. if (WARN_ON(len < 2))
  135. return;
  136. if (ieee80211_is_deauth(mgmt->frame_control))
  137. - cfg80211_process_deauth(wdev, buf, len);
  138. + cfg80211_process_deauth(wdev, buf, len, reconnect);
  139. else
  140. - cfg80211_process_disassoc(wdev, buf, len);
  141. + cfg80211_process_disassoc(wdev, buf, len, reconnect);
  142. }
  143. EXPORT_SYMBOL(cfg80211_tx_mlme_mgmt);
  144. --- a/net/wireless/nl80211.c
  145. +++ b/net/wireless/nl80211.c
  146. @@ -732,6 +732,7 @@ static const struct nla_policy nl80211_p
  147. NLA_POLICY_EXACT_LEN(IEEE80211_S1G_CAPABILITY_LEN),
  148. [NL80211_ATTR_S1G_CAPABILITY_MASK] =
  149. NLA_POLICY_EXACT_LEN(IEEE80211_S1G_CAPABILITY_LEN),
  150. + [NL80211_ATTR_RECONNECT_REQUESTED] = { .type = NLA_REJECT },
  151. };
  152. /* policy for the key attributes */
  153. @@ -15899,7 +15900,7 @@ static void nl80211_send_mlme_event(stru
  154. const u8 *buf, size_t len,
  155. enum nl80211_commands cmd, gfp_t gfp,
  156. int uapsd_queues, const u8 *req_ies,
  157. - size_t req_ies_len)
  158. + size_t req_ies_len, bool reconnect)
  159. {
  160. struct sk_buff *msg;
  161. void *hdr;
  162. @@ -15921,6 +15922,9 @@ static void nl80211_send_mlme_event(stru
  163. nla_put(msg, NL80211_ATTR_REQ_IE, req_ies_len, req_ies)))
  164. goto nla_put_failure;
  165. + if (reconnect && nla_put_flag(msg, NL80211_ATTR_RECONNECT_REQUESTED))
  166. + goto nla_put_failure;
  167. +
  168. if (uapsd_queues >= 0) {
  169. struct nlattr *nla_wmm =
  170. nla_nest_start_noflag(msg, NL80211_ATTR_STA_WME);
  171. @@ -15949,7 +15953,8 @@ void nl80211_send_rx_auth(struct cfg8021
  172. size_t len, gfp_t gfp)
  173. {
  174. nl80211_send_mlme_event(rdev, netdev, buf, len,
  175. - NL80211_CMD_AUTHENTICATE, gfp, -1, NULL, 0);
  176. + NL80211_CMD_AUTHENTICATE, gfp, -1, NULL, 0,
  177. + false);
  178. }
  179. void nl80211_send_rx_assoc(struct cfg80211_registered_device *rdev,
  180. @@ -15959,23 +15964,25 @@ void nl80211_send_rx_assoc(struct cfg802
  181. {
  182. nl80211_send_mlme_event(rdev, netdev, buf, len,
  183. NL80211_CMD_ASSOCIATE, gfp, uapsd_queues,
  184. - req_ies, req_ies_len);
  185. + req_ies, req_ies_len, false);
  186. }
  187. void nl80211_send_deauth(struct cfg80211_registered_device *rdev,
  188. struct net_device *netdev, const u8 *buf,
  189. - size_t len, gfp_t gfp)
  190. + size_t len, bool reconnect, gfp_t gfp)
  191. {
  192. nl80211_send_mlme_event(rdev, netdev, buf, len,
  193. - NL80211_CMD_DEAUTHENTICATE, gfp, -1, NULL, 0);
  194. + NL80211_CMD_DEAUTHENTICATE, gfp, -1, NULL, 0,
  195. + reconnect);
  196. }
  197. void nl80211_send_disassoc(struct cfg80211_registered_device *rdev,
  198. struct net_device *netdev, const u8 *buf,
  199. - size_t len, gfp_t gfp)
  200. + size_t len, bool reconnect, gfp_t gfp)
  201. {
  202. nl80211_send_mlme_event(rdev, netdev, buf, len,
  203. - NL80211_CMD_DISASSOCIATE, gfp, -1, NULL, 0);
  204. + NL80211_CMD_DISASSOCIATE, gfp, -1, NULL, 0,
  205. + reconnect);
  206. }
  207. void cfg80211_rx_unprot_mlme_mgmt(struct net_device *dev, const u8 *buf,
  208. @@ -16006,7 +16013,7 @@ void cfg80211_rx_unprot_mlme_mgmt(struct
  209. trace_cfg80211_rx_unprot_mlme_mgmt(dev, buf, len);
  210. nl80211_send_mlme_event(rdev, dev, buf, len, cmd, GFP_ATOMIC, -1,
  211. - NULL, 0);
  212. + NULL, 0, false);
  213. }
  214. EXPORT_SYMBOL(cfg80211_rx_unprot_mlme_mgmt);
  215. --- a/net/wireless/nl80211.h
  216. +++ b/net/wireless/nl80211.h
  217. @@ -1,7 +1,7 @@
  218. /* SPDX-License-Identifier: GPL-2.0 */
  219. /*
  220. * Portions of this file
  221. - * Copyright (C) 2018 Intel Corporation
  222. + * Copyright (C) 2018, 2020 Intel Corporation
  223. */
  224. #ifndef __NET_WIRELESS_NL80211_H
  225. #define __NET_WIRELESS_NL80211_H
  226. @@ -69,10 +69,12 @@ void nl80211_send_rx_assoc(struct cfg802
  227. const u8 *req_ies, size_t req_ies_len);
  228. void nl80211_send_deauth(struct cfg80211_registered_device *rdev,
  229. struct net_device *netdev,
  230. - const u8 *buf, size_t len, gfp_t gfp);
  231. + const u8 *buf, size_t len,
  232. + bool reconnect, gfp_t gfp);
  233. void nl80211_send_disassoc(struct cfg80211_registered_device *rdev,
  234. struct net_device *netdev,
  235. - const u8 *buf, size_t len, gfp_t gfp);
  236. + const u8 *buf, size_t len,
  237. + bool reconnect, gfp_t gfp);
  238. void nl80211_send_auth_timeout(struct cfg80211_registered_device *rdev,
  239. struct net_device *netdev,
  240. const u8 *addr, gfp_t gfp);
  241. --- a/net/wireless/trace.h
  242. +++ b/net/wireless/trace.h
  243. @@ -2684,19 +2684,23 @@ DEFINE_EVENT(netdev_frame_event, cfg8021
  244. );
  245. TRACE_EVENT(cfg80211_tx_mlme_mgmt,
  246. - TP_PROTO(struct net_device *netdev, const u8 *buf, int len),
  247. - TP_ARGS(netdev, buf, len),
  248. + TP_PROTO(struct net_device *netdev, const u8 *buf, int len,
  249. + bool reconnect),
  250. + TP_ARGS(netdev, buf, len, reconnect),
  251. TP_STRUCT__entry(
  252. NETDEV_ENTRY
  253. __dynamic_array(u8, frame, len)
  254. + __field(int, reconnect)
  255. ),
  256. TP_fast_assign(
  257. NETDEV_ASSIGN;
  258. memcpy(__get_dynamic_array(frame), buf, len);
  259. + __entry->reconnect = reconnect;
  260. ),
  261. - TP_printk(NETDEV_PR_FMT ", ftype:0x%.2x",
  262. + TP_printk(NETDEV_PR_FMT ", ftype:0x%.2x reconnect:%d",
  263. NETDEV_PR_ARG,
  264. - le16_to_cpup((__le16 *)__get_dynamic_array(frame)))
  265. + le16_to_cpup((__le16 *)__get_dynamic_array(frame)),
  266. + __entry->reconnect)
  267. );
  268. DECLARE_EVENT_CLASS(netdev_mac_evt,