850-0009-PCI-aardvark-Refactor-unmasking-summary-MSI-interrup.patch 1.6 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344
  1. From 98feaf97bc64fc640a6c5b1394cd18fc7cd7dac8 Mon Sep 17 00:00:00 2001
  2. From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <[email protected]>
  3. Date: Sun, 28 Mar 2021 14:34:49 +0200
  4. Subject: [PATCH] PCI: aardvark: Refactor unmasking summary MSI interrupt
  5. MIME-Version: 1.0
  6. Content-Type: text/plain; charset=UTF-8
  7. Content-Transfer-Encoding: 8bit
  8. Refactor the masking of ISR0/1 Sources and unmasking of summary MSI interrupt
  9. so that it corresponds to the comments:
  10. - first mask all ISR0/1
  11. - then unmask all MSIs
  12. - then unmask summary MSI interrupt
  13. Signed-off-by: Pali Rohár <[email protected]>
  14. Signed-off-by: Marek Behún <[email protected]>
  15. ---
  16. drivers/pci/controller/pci-aardvark.c | 10 ++++++----
  17. 1 file changed, 6 insertions(+), 4 deletions(-)
  18. --- a/drivers/pci/controller/pci-aardvark.c
  19. +++ b/drivers/pci/controller/pci-aardvark.c
  20. @@ -578,15 +578,17 @@ static void advk_pcie_setup_hw(struct ad
  21. advk_writel(pcie, PCIE_IRQ_ALL_MASK, HOST_CTRL_INT_STATUS_REG);
  22. /* Disable All ISR0/1 Sources */
  23. - reg = PCIE_ISR0_ALL_MASK;
  24. - reg &= ~PCIE_ISR0_MSI_INT_PENDING;
  25. - advk_writel(pcie, reg, PCIE_ISR0_MASK_REG);
  26. -
  27. + advk_writel(pcie, PCIE_ISR0_ALL_MASK, PCIE_ISR0_MASK_REG);
  28. advk_writel(pcie, PCIE_ISR1_ALL_MASK, PCIE_ISR1_MASK_REG);
  29. /* Unmask all MSIs */
  30. advk_writel(pcie, ~(u32)PCIE_MSI_ALL_MASK, PCIE_MSI_MASK_REG);
  31. + /* Unmask summary MSI interrupt */
  32. + reg = advk_readl(pcie, PCIE_ISR0_MASK_REG);
  33. + reg &= ~PCIE_ISR0_MSI_INT_PENDING;
  34. + advk_writel(pcie, reg, PCIE_ISR0_MASK_REG);
  35. +
  36. /* Enable summary interrupt for GIC SPI source */
  37. reg = PCIE_IRQ_ALL_MASK & (~PCIE_IRQ_ENABLE_INTS_MASK);
  38. advk_writel(pcie, reg, HOST_CTRL_INT_MASK_REG);