| 12345678910111213141516171819202122232425262728293031 |
- From 97e176fcbbf3c0f2bd410c9b241177c051f57176 Mon Sep 17 00:00:00 2001
- From: Heiner Kallweit <[email protected]>
- Date: Wed, 10 Apr 2024 15:11:28 +0200
- Subject: [PATCH] r8169: add missing conditional compiling for call to
- r8169_remove_leds
- Add missing dependency on CONFIG_R8169_LEDS. As-is a link error occurs
- if config option CONFIG_R8169_LEDS isn't enabled.
- Fixes: 19fa4f2a85d7 ("r8169: fix LED-related deadlock on module removal")
- Reported-by: Venkat Rao Bagalkote <[email protected]>
- Signed-off-by: Heiner Kallweit <[email protected]>
- Tested-By: Venkat Rao Bagalkote <[email protected]>
- Link: https://lore.kernel.org/r/[email protected]
- Signed-off-by: Jakub Kicinski <[email protected]>
- ---
- drivers/net/ethernet/realtek/r8169_main.c | 3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
- --- a/drivers/net/ethernet/realtek/r8169_main.c
- +++ b/drivers/net/ethernet/realtek/r8169_main.c
- @@ -5071,7 +5071,8 @@ static void rtl_remove_one(struct pci_de
-
- cancel_work_sync(&tp->wk.work);
-
- - r8169_remove_leds(tp->leds);
- + if (IS_ENABLED(CONFIG_R8169_LEDS))
- + r8169_remove_leds(tp->leds);
-
- unregister_netdev(tp->dev);
-
|