312-rt2x00-Fix-TX-descriptor-usage-rt2800usb.patch 4.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112
  1. From e9a3a3b9744f0204ec4beec8f9bea3c11ce6f54b Mon Sep 17 00:00:00 2001
  2. From: Ivo van Doorn <[email protected]>
  3. Date: Sat, 10 Jan 2009 19:21:46 +0100
  4. Subject: [PATCH] rt2x00: Fix TX descriptor usage (rt2800usb)
  5. Signed-off-by: Ivo van Doorn <[email protected]>
  6. ---
  7. drivers/net/wireless/rt2x00/rt2800usb.c | 46 ++++++++++---------------------
  8. drivers/net/wireless/rt2x00/rt2800usb.h | 1 +
  9. 2 files changed, 16 insertions(+), 31 deletions(-)
  10. --- a/drivers/net/wireless/rt2x00/rt2800usb.c
  11. +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
  12. @@ -1635,8 +1635,8 @@ static void rt2800usb_write_tx_desc(stru
  13. struct txentry_desc *txdesc)
  14. {
  15. struct skb_frame_desc *skbdesc = get_skb_frame_desc(skb);
  16. - __le32 *txd = skbdesc->desc;
  17. - __le32 *txwi = txd + TXD_DESC_SIZE;
  18. + __le32 *txi = skbdesc->desc;
  19. + __le32 *txwi = txi + TXINFO_DESC_SIZE;
  20. u32 word;
  21. /*
  22. @@ -1683,31 +1683,15 @@ static void rt2800usb_write_tx_desc(stru
  23. /*
  24. * Initialize TX descriptor
  25. */
  26. - rt2x00_desc_read(txd, 0, &word);
  27. - rt2x00_set_field32(&word, TXD_W0_SD_PTR0, skbdesc->skb_dma);
  28. - rt2x00_desc_write(txd, 0, word);
  29. -
  30. - rt2x00_desc_read(txd, 1, &word);
  31. - rt2x00_set_field32(&word, TXD_W1_SD_LEN1, skb->len);
  32. - rt2x00_set_field32(&word, TXD_W1_LAST_SEC1, 1);
  33. - rt2x00_set_field32(&word, TXD_W1_BURST,
  34. + rt2x00_desc_read(txi, 0, &word);
  35. + rt2x00_set_field32(&word, TXINFO_W0_USB_DMA_TX_PKT_LEN, skb->len);
  36. + rt2x00_set_field32(&word, TXINFO_W0_WIV, 1);
  37. + rt2x00_set_field32(&word, TXINFO_W0_QSEL, 2);
  38. + rt2x00_set_field32(&word, TXINFO_W0_SW_USE_LAST_ROUND, 0);
  39. + rt2x00_set_field32(&word, TXINFO_W0_USB_DMA_NEXT_VALID, 0);
  40. + rt2x00_set_field32(&word, TXINFO_W0_USB_DMA_TX_BURST,
  41. test_bit(ENTRY_TXD_BURST, &txdesc->flags));
  42. - rt2x00_set_field32(&word, TXD_W1_SD_LEN0,
  43. - rt2x00dev->hw->extra_tx_headroom);
  44. - rt2x00_set_field32(&word, TXD_W1_LAST_SEC0,
  45. - !test_bit(ENTRY_TXD_MORE_FRAG, &txdesc->flags));
  46. - rt2x00_set_field32(&word, TXD_W1_DMA_DONE, 0);
  47. - rt2x00_desc_write(txd, 1, word);
  48. -
  49. - rt2x00_desc_read(txd, 2, &word);
  50. - rt2x00_set_field32(&word, TXD_W2_SD_PTR1,
  51. - skbdesc->skb_dma + rt2x00dev->hw->extra_tx_headroom);
  52. - rt2x00_desc_write(txd, 2, word);
  53. -
  54. - rt2x00_desc_read(txd, 3, &word);
  55. - rt2x00_set_field32(&word, TXD_W3_WIV, 1);
  56. - rt2x00_set_field32(&word, TXD_W3_QSEL, 2);
  57. - rt2x00_desc_write(txd, 3, word);
  58. + rt2x00_desc_write(txi, 0, word);
  59. }
  60. /*
  61. @@ -1881,9 +1865,9 @@ static void rt2800usb_fill_rxdone(struct
  62. rxdesc->size = rt2x00_get_field32(rxwi0, RXWI_W0_MPDU_TOTAL_BYTE_COUNT);
  63. /*
  64. - * Remove TXWI descriptor from start of buffer.
  65. + * Remove RXWI descriptor from start of buffer.
  66. */
  67. - skb_pull(entry->skb, TXWI_DESC_SIZE + skbdesc->desc_len);
  68. + skb_pull(entry->skb, RXWI_DESC_SIZE + skbdesc->desc_len);
  69. skb_trim(entry->skb, rxdesc->size);
  70. }
  71. @@ -2146,7 +2130,7 @@ static int rt2800usb_probe_hw_mode(struc
  72. IEEE80211_HW_SIGNAL_DBM |
  73. IEEE80211_HW_SUPPORTS_PS |
  74. IEEE80211_HW_PS_NULLFUNC_STACK;
  75. - rt2x00dev->hw->extra_tx_headroom = TXD_DESC_SIZE + TXINFO_DESC_SIZE;
  76. + rt2x00dev->hw->extra_tx_headroom = TXINFO_DESC_SIZE + TXWI_DESC_SIZE;
  77. SET_IEEE80211_DEV(rt2x00dev->hw, rt2x00dev->dev);
  78. SET_IEEE80211_PERM_ADDR(rt2x00dev->hw,
  79. @@ -2445,14 +2429,14 @@ static const struct data_queue_desc rt28
  80. static const struct data_queue_desc rt2800usb_queue_tx = {
  81. .entry_num = TX_ENTRIES,
  82. .data_size = DATA_FRAME_SIZE,
  83. - .desc_size = TXD_DESC_SIZE,
  84. + .desc_size = TXINFO_DESC_SIZE + TXWI_DESC_SIZE,
  85. .priv_size = sizeof(struct queue_entry_priv_usb),
  86. };
  87. static const struct data_queue_desc rt2800usb_queue_bcn = {
  88. .entry_num = 8 * BEACON_ENTRIES,
  89. .data_size = MGMT_FRAME_SIZE,
  90. - .desc_size = TXWI_DESC_SIZE,
  91. + .desc_size = TXINFO_DESC_SIZE + TXWI_DESC_SIZE,
  92. .priv_size = sizeof(struct queue_entry_priv_usb),
  93. };
  94. --- a/drivers/net/wireless/rt2x00/rt2800usb.h
  95. +++ b/drivers/net/wireless/rt2x00/rt2800usb.h
  96. @@ -1744,6 +1744,7 @@ struct hw_key_entry {
  97. #define TXINFO_W0_USB_DMA_TX_PKT_LEN FIELD32(0x0000ffff)
  98. #define TXINFO_W0_WIV FIELD32(0x01000000)
  99. #define TXINFO_W0_QSEL FIELD32(0x06000000)
  100. +#define TXINFO_W0_SW_USE_LAST_ROUND FIELD32(0x08000000)
  101. #define TXINFO_W0_USB_DMA_NEXT_VALID FIELD32(0x40000000)
  102. #define TXINFO_W0_USB_DMA_TX_BURST FIELD32(0x80000000)