| 1234567891011121314151617181920212223242526272829303132333435 |
- From cee4bd16c3195a701be683f7da9e88c6e11acb73 Mon Sep 17 00:00:00 2001
- From: Christian Marangi <[email protected]>
- Date: Wed, 19 Apr 2023 23:07:39 +0200
- Subject: [PATCH 1/5] leds: trigger: netdev: Recheck NETDEV_LED_MODE_LINKUP on
- dev rename
- Dev can be renamed also while up for supported device. We currently
- wrongly clear the NETDEV_LED_MODE_LINKUP flag on NETDEV_CHANGENAME
- event.
- Fix this by rechecking if the carrier is ok on NETDEV_CHANGENAME and
- correctly set the NETDEV_LED_MODE_LINKUP bit.
- Fixes: 5f820ed52371 ("leds: trigger: netdev: fix handling on interface rename")
- Cc: [email protected] # v5.5+
- Signed-off-by: Christian Marangi <[email protected]>
- Reviewed-by: Andrew Lunn <[email protected]>
- Signed-off-by: Lee Jones <[email protected]>
- Link: https://lore.kernel.org/r/[email protected]
- ---
- drivers/leds/trigger/ledtrig-netdev.c | 3 +++
- 1 file changed, 3 insertions(+)
- --- a/drivers/leds/trigger/ledtrig-netdev.c
- +++ b/drivers/leds/trigger/ledtrig-netdev.c
- @@ -318,6 +318,9 @@ static int netdev_trig_notify(struct not
- clear_bit(NETDEV_LED_MODE_LINKUP, &trigger_data->mode);
- switch (evt) {
- case NETDEV_CHANGENAME:
- + if (netif_carrier_ok(dev))
- + set_bit(NETDEV_LED_MODE_LINKUP, &trigger_data->mode);
- + fallthrough;
- case NETDEV_REGISTER:
- if (trigger_data->net_dev)
- dev_put(trigger_data->net_dev);
|
