| 12345678910111213141516171819202122232425262728293031323334 |
- From e31dbd3b6aba585231cd84a87adeb22e7c6a8c19 Mon Sep 17 00:00:00 2001
- From: Vladimir Oltean <[email protected]>
- Date: Thu, 6 Jan 2022 01:11:13 +0200
- Subject: [PATCH 2/6] net: dsa: merge rtnl_lock sections in dsa_slave_create
- Currently dsa_slave_create() has two sequences of rtnl_lock/rtnl_unlock
- in a row. Remove the rtnl_unlock() and rtnl_lock() in between, such that
- the operation can execute slighly faster.
- Signed-off-by: Vladimir Oltean <[email protected]>
- Reviewed-by: Florian Fainelli <[email protected]>
- Signed-off-by: David S. Miller <[email protected]>
- ---
- net/dsa/slave.c | 4 +---
- 1 file changed, 1 insertion(+), 3 deletions(-)
- --- a/net/dsa/slave.c
- +++ b/net/dsa/slave.c
- @@ -1988,14 +1988,12 @@ int dsa_slave_create(struct dsa_port *po
- }
-
- rtnl_lock();
- +
- ret = dsa_slave_change_mtu(slave_dev, ETH_DATA_LEN);
- - rtnl_unlock();
- if (ret && ret != -EOPNOTSUPP)
- dev_warn(ds->dev, "nonfatal error %d setting MTU to %d on port %d\n",
- ret, ETH_DATA_LEN, port->index);
-
- - rtnl_lock();
- -
- ret = register_netdevice(slave_dev);
- if (ret) {
- netdev_err(master, "error %d registering interface %s\n",
|
