| 12345678910111213141516171819202122232425262728293031323334 |
- From dc90895d776d7b8017bc3b14f588d569d8edbe1f Mon Sep 17 00:00:00 2001
- From: Jonas Gorski <[email protected]>
- Date: Thu, 11 May 2017 13:36:52 +0200
- Subject: [PATCH] leds: bcm6328: fix signal source assignment for high leds
- Each nibble represents 4 LEDs, and in case of the higher register, bit 0
- represents LED 4, so we need to use modulus for the LED number as well.
- Fixes: fd7b025a238d0a5440bfa26c585eb78097bf48dc ("leds: add BCM6328 LED driver")
- Signed-off-by: Jonas Gorski <[email protected]>
- ---
- drivers/leds/leds-bcm6328.c | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
- --- a/drivers/leds/leds-bcm6328.c
- +++ b/drivers/leds/leds-bcm6328.c
- @@ -242,7 +242,7 @@ static int bcm6328_hwled(struct device *
-
- spin_lock_irqsave(lock, flags);
- val = bcm6328_led_read(addr);
- - val |= (BIT(reg) << (((sel % 4) * 4) + 16));
- + val |= (BIT(reg % 4) << (((sel % 4) * 4) + 16));
- bcm6328_led_write(addr, val);
- spin_unlock_irqrestore(lock, flags);
- }
- @@ -269,7 +269,7 @@ static int bcm6328_hwled(struct device *
-
- spin_lock_irqsave(lock, flags);
- val = bcm6328_led_read(addr);
- - val |= (BIT(reg) << ((sel % 4) * 4));
- + val |= (BIT(reg % 4) << ((sel % 4) * 4));
- bcm6328_led_write(addr, val);
- spin_unlock_irqrestore(lock, flags);
- }
|
