150-C-feature-checks-Match-warnings-more-strictly.patch 1.1 KB

12345678910111213141516171819202122232425
  1. From 4ca5a815f2dfe9e1116cc2ccd5ddb56d0d00d12e Mon Sep 17 00:00:00 2001
  2. From: Brad King <[email protected]>
  3. Date: Thu, 7 Mar 2019 14:55:54 -0500
  4. Subject: [PATCH] C++ feature checks: Match warnings more strictly
  5. Require the word "warning" to appear at the start of a line, after
  6. whitespace, or after a `:`. This is the same that CTest launchers use
  7. to match warnings. It avoids matching "warning" inside file paths.
  8. Fixes: #19019
  9. ---
  10. Source/Checks/cm_cxx_features.cmake | 2 +-
  11. 1 file changed, 1 insertion(+), 1 deletion(-)
  12. --- a/Source/Checks/cm_cxx_features.cmake
  13. +++ b/Source/Checks/cm_cxx_features.cmake
  14. @@ -25,7 +25,7 @@ function(cm_check_cxx_feature name)
  15. # Filter out xcodebuild warnings.
  16. string(REGEX REPLACE "[^\n]* xcodebuild\\[[0-9]*:[0-9]*\\] warning: [^\n]*" "" check_output "${check_output}")
  17. # If using the feature causes warnings, treat it as broken/unavailable.
  18. - if(check_output MATCHES "[Ww]arning")
  19. + if(check_output MATCHES "(^|[ :])[Ww][Aa][Rr][Nn][Ii][Nn][Gg]")
  20. set(CMake_HAVE_CXX_${FEATURE} OFF CACHE INTERNAL "TRY_COMPILE" FORCE)
  21. endif()
  22. if(CMake_HAVE_CXX_${FEATURE})