441-block2mtd_refresh.patch 6.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292
  1. --- a/drivers/mtd/devices/block2mtd.c
  2. +++ b/drivers/mtd/devices/block2mtd.c
  3. @@ -30,6 +30,8 @@ struct block2mtd_dev {
  4. struct block_device *blkdev;
  5. struct mtd_info mtd;
  6. struct mutex write_mutex;
  7. + rwlock_t bdev_mutex;
  8. + char devname[0];
  9. };
  10. @@ -82,6 +84,12 @@ static int block2mtd_erase(struct mtd_in
  11. size_t len = instr->len;
  12. int err;
  13. + read_lock(&dev->bdev_mutex);
  14. + if (!dev->blkdev) {
  15. + err = -EINVAL;
  16. + goto done;
  17. + }
  18. +
  19. instr->state = MTD_ERASING;
  20. mutex_lock(&dev->write_mutex);
  21. err = _block2mtd_erase(dev, from, len);
  22. @@ -93,6 +101,10 @@ static int block2mtd_erase(struct mtd_in
  23. instr->state = MTD_ERASE_DONE;
  24. mtd_erase_callback(instr);
  25. +
  26. +done:
  27. + read_unlock(&dev->bdev_mutex);
  28. +
  29. return err;
  30. }
  31. @@ -104,10 +116,14 @@ static int block2mtd_read(struct mtd_inf
  32. struct page *page;
  33. int index = from >> PAGE_SHIFT;
  34. int offset = from & (PAGE_SIZE-1);
  35. - int cpylen;
  36. + int cpylen, err = 0;
  37. +
  38. + read_lock(&dev->bdev_mutex);
  39. + if (!dev->blkdev || (from > mtd->size)) {
  40. + err = -EINVAL;
  41. + goto done;
  42. + }
  43. - if (from > mtd->size)
  44. - return -EINVAL;
  45. if (from + len > mtd->size)
  46. len = mtd->size - from;
  47. @@ -122,10 +138,14 @@ static int block2mtd_read(struct mtd_inf
  48. len = len - cpylen;
  49. page = page_read(dev->blkdev->bd_inode->i_mapping, index);
  50. - if (!page)
  51. - return -ENOMEM;
  52. - if (IS_ERR(page))
  53. - return PTR_ERR(page);
  54. + if (!page) {
  55. + err = -ENOMEM;
  56. + goto done;
  57. + }
  58. + if (IS_ERR(page)) {
  59. + err = PTR_ERR(page);
  60. + goto done;
  61. + }
  62. memcpy(buf, page_address(page) + offset, cpylen);
  63. page_cache_release(page);
  64. @@ -136,7 +156,10 @@ static int block2mtd_read(struct mtd_inf
  65. offset = 0;
  66. index++;
  67. }
  68. - return 0;
  69. +
  70. +done:
  71. + read_unlock(&dev->bdev_mutex);
  72. + return err;
  73. }
  74. @@ -188,12 +211,22 @@ static int block2mtd_write(struct mtd_in
  75. size_t *retlen, const u_char *buf)
  76. {
  77. struct block2mtd_dev *dev = mtd->priv;
  78. - int err;
  79. + int err = 0;
  80. +
  81. + read_lock(&dev->bdev_mutex);
  82. + if (!dev->blkdev) {
  83. + err = -EINVAL;
  84. + goto done;
  85. + }
  86. if (!len)
  87. - return 0;
  88. - if (to >= mtd->size)
  89. - return -ENOSPC;
  90. + goto done;
  91. +
  92. + if (to >= mtd->size) {
  93. + err = -ENOSPC;
  94. + goto done;
  95. + }
  96. +
  97. if (to + len > mtd->size)
  98. len = mtd->size - to;
  99. @@ -202,6 +235,9 @@ static int block2mtd_write(struct mtd_in
  100. mutex_unlock(&dev->write_mutex);
  101. if (err > 0)
  102. err = 0;
  103. +
  104. +done:
  105. + read_unlock(&dev->bdev_mutex);
  106. return err;
  107. }
  108. @@ -210,52 +246,29 @@ static int block2mtd_write(struct mtd_in
  109. static void block2mtd_sync(struct mtd_info *mtd)
  110. {
  111. struct block2mtd_dev *dev = mtd->priv;
  112. - sync_blockdev(dev->blkdev);
  113. - return;
  114. -}
  115. -
  116. -
  117. -static void block2mtd_free_device(struct block2mtd_dev *dev)
  118. -{
  119. - if (!dev)
  120. - return;
  121. -
  122. - kfree(dev->mtd.name);
  123. - if (dev->blkdev) {
  124. - invalidate_mapping_pages(dev->blkdev->bd_inode->i_mapping,
  125. - 0, -1);
  126. - close_bdev_exclusive(dev->blkdev, FMODE_READ|FMODE_WRITE);
  127. - }
  128. + read_lock(&dev->bdev_mutex);
  129. + if (dev->blkdev)
  130. + sync_blockdev(dev->blkdev);
  131. + read_unlock(&dev->bdev_mutex);
  132. - kfree(dev);
  133. + return;
  134. }
  135. -/* FIXME: ensure that mtd->size % erase_size == 0 */
  136. -static struct block2mtd_dev *add_device(char *devname, int erase_size, const char *mtdname)
  137. +static int _open_bdev(struct block2mtd_dev *dev)
  138. {
  139. struct block_device *bdev;
  140. - struct block2mtd_dev *dev;
  141. - struct mtd_partition *part;
  142. - char *name;
  143. -
  144. - if (!devname)
  145. - return NULL;
  146. -
  147. - dev = kzalloc(sizeof(struct block2mtd_dev), GFP_KERNEL);
  148. - if (!dev)
  149. - return NULL;
  150. /* Get a handle on the device */
  151. - bdev = open_bdev_exclusive(devname, FMODE_READ|FMODE_WRITE, NULL);
  152. + bdev = open_bdev_exclusive(dev->devname, FMODE_READ|FMODE_WRITE, NULL);
  153. #ifndef MODULE
  154. if (IS_ERR(bdev)) {
  155. /* We might not have rootfs mounted at this point. Try
  156. to resolve the device name by other means. */
  157. - dev_t devt = name_to_dev_t(devname);
  158. + dev_t devt = name_to_dev_t(dev->devname);
  159. if (devt) {
  160. bdev = open_by_devnum(devt, FMODE_WRITE | FMODE_READ);
  161. }
  162. @@ -263,17 +276,98 @@ static struct block2mtd_dev *add_device(
  163. #endif
  164. if (IS_ERR(bdev)) {
  165. - ERROR("error: cannot open device %s", devname);
  166. - goto devinit_err;
  167. + ERROR("error: cannot open device %s", dev->devname);
  168. + return 1;
  169. }
  170. dev->blkdev = bdev;
  171. if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) {
  172. ERROR("attempting to use an MTD device as a block device");
  173. - goto devinit_err;
  174. + return 1;
  175. }
  176. + return 0;
  177. +}
  178. +
  179. +static void _close_bdev(struct block2mtd_dev *dev)
  180. +{
  181. + struct block_device *bdev;
  182. +
  183. + if (!dev->blkdev)
  184. + return;
  185. +
  186. + bdev = dev->blkdev;
  187. + invalidate_mapping_pages(dev->blkdev->bd_inode->i_mapping, 0, -1);
  188. + close_bdev_exclusive(dev->blkdev, FMODE_READ|FMODE_WRITE);
  189. + dev->blkdev = NULL;
  190. +}
  191. +
  192. +static void block2mtd_free_device(struct block2mtd_dev *dev)
  193. +{
  194. + if (!dev)
  195. + return;
  196. +
  197. + kfree(dev->mtd.name);
  198. + _close_bdev(dev);
  199. + kfree(dev);
  200. +}
  201. +
  202. +
  203. +static int block2mtd_refresh(struct mtd_info *mtd)
  204. +{
  205. + struct block2mtd_dev *dev = mtd->priv;
  206. + struct block_device *bdev;
  207. + dev_t devt;
  208. + int err = 0;
  209. +
  210. + /* no other mtd function can run at this point */
  211. + write_lock(&dev->bdev_mutex);
  212. +
  213. + /* get the device number for the whole disk */
  214. + devt = MKDEV(MAJOR(dev->blkdev->bd_dev), 0);
  215. +
  216. + /* close the old block device */
  217. + _close_bdev(dev);
  218. +
  219. + /* open the whole disk, issue a partition rescan, then */
  220. + bdev = open_by_devnum(devt, FMODE_WRITE | FMODE_READ);
  221. + if (!bdev || !bdev->bd_disk)
  222. + err = -EINVAL;
  223. +#ifndef CONFIG_MTD_BLOCK2MTD_MODULE
  224. + else
  225. + err = rescan_partitions(bdev->bd_disk, bdev);
  226. +#endif
  227. + if (bdev)
  228. + close_bdev_exclusive(bdev, FMODE_READ|FMODE_WRITE);
  229. +
  230. + /* try to open the partition block device again */
  231. + _open_bdev(dev);
  232. + write_unlock(&dev->bdev_mutex);
  233. +
  234. + return err;
  235. +}
  236. +
  237. +/* FIXME: ensure that mtd->size % erase_size == 0 */
  238. +static struct block2mtd_dev *add_device(char *devname, int erase_size, char *mtdname)
  239. +{
  240. + struct block2mtd_dev *dev;
  241. + struct mtd_partition *part;
  242. + char *name;
  243. +
  244. + if (!devname)
  245. + return NULL;
  246. +
  247. + dev = kzalloc(sizeof(struct block2mtd_dev) + strlen(devname) + 1, GFP_KERNEL);
  248. + if (!dev)
  249. + return NULL;
  250. +
  251. + strcpy(dev->devname, devname);
  252. +
  253. + if (_open_bdev(dev))
  254. + goto devinit_err;
  255. +
  256. mutex_init(&dev->write_mutex);
  257. + rwlock_init(&dev->bdev_mutex);
  258. /* Setup the MTD structure */
  259. /* make the name contain the block device in */
  260. @@ -298,6 +392,7 @@ static struct block2mtd_dev *add_device(
  261. dev->mtd.read = block2mtd_read;
  262. dev->mtd.priv = dev;
  263. dev->mtd.owner = THIS_MODULE;
  264. + dev->mtd.refresh_device = block2mtd_refresh;
  265. part = kzalloc(sizeof(struct mtd_partition), GFP_KERNEL);
  266. part->name = dev->mtd.name;