| 123456789101112131415161718192021222324252627282930313233343536 |
- From f2ec98566775dd4341ec1dcf93aa5859c60de826 Mon Sep 17 00:00:00 2001
- From: Christian Marangi <[email protected]>
- Date: Thu, 1 Feb 2024 14:46:00 +0100
- Subject: [PATCH 1/2] net: phy: qcom: qca808x: fix logic error in LED
- brightness set
- In switching to using phy_modify_mmd and a more short version of the
- LED ON/OFF condition in later revision, it was made a logic error where
- value ? QCA808X_LED_FORCE_ON : QCA808X_LED_FORCE_OFF is always true as
- value is always OR with QCA808X_LED_FORCE_EN due to missing ()
- resulting in the testing condition being QCA808X_LED_FORCE_EN | value.
- Add the () to apply the correct condition and restore correct
- functionality of the brightness ON/OFF.
- Fixes: 7196062b64ee ("net: phy: at803x: add LED support for qca808x")
- Signed-off-by: Christian Marangi <[email protected]>
- Signed-off-by: David S. Miller <[email protected]>
- ---
- drivers/net/phy/qcom/qca808x.c | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
- --- a/drivers/net/phy/qcom/qca808x.c
- +++ b/drivers/net/phy/qcom/qca808x.c
- @@ -820,8 +820,8 @@ static int qca808x_led_brightness_set(st
-
- return phy_modify_mmd(phydev, MDIO_MMD_AN, reg,
- QCA808X_LED_FORCE_EN | QCA808X_LED_FORCE_MODE_MASK,
- - QCA808X_LED_FORCE_EN | value ? QCA808X_LED_FORCE_ON :
- - QCA808X_LED_FORCE_OFF);
- + QCA808X_LED_FORCE_EN | (value ? QCA808X_LED_FORCE_ON :
- + QCA808X_LED_FORCE_OFF));
- }
-
- static int qca808x_led_blink_set(struct phy_device *phydev, u8 index,
|
