950-0442-drm-vc4-hdmi-Simplify-the-connector-state-retrieval.patch 1.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051
  1. From fbd09981ff7ecefd9514325bdbfa2b4df4b4f017 Mon Sep 17 00:00:00 2001
  2. From: Maxime Ripard <[email protected]>
  3. Date: Wed, 27 Oct 2021 14:38:50 +0100
  4. Subject: [PATCH] drm/vc4: hdmi: Simplify the connector state retrieval
  5. When we have the entire DRM state, retrieving the connector state only
  6. requires the drm_connector pointer. Fortunately for us, we have
  7. allocated it as a part of the vc4_hdmi structure, so we can retrieve get
  8. a pointer by simply accessing our field in that structure.
  9. Signed-off-by: Maxime Ripard <[email protected]>
  10. ---
  11. drivers/gpu/drm/vc4/vc4_hdmi.c | 21 +++------------------
  12. 1 file changed, 3 insertions(+), 18 deletions(-)
  13. --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
  14. +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
  15. @@ -1012,30 +1012,15 @@ static void vc4_hdmi_recenter_fifo(struc
  16. "VC4_HDMI_FIFO_CTL_RECENTER_DONE");
  17. }
  18. -static struct drm_connector_state *
  19. -vc4_hdmi_encoder_get_connector_state(struct drm_encoder *encoder,
  20. - struct drm_atomic_state *state)
  21. -{
  22. - struct drm_connector_state *conn_state;
  23. - struct drm_connector *connector;
  24. - unsigned int i;
  25. -
  26. - for_each_new_connector_in_state(state, connector, conn_state, i) {
  27. - if (conn_state->best_encoder == encoder)
  28. - return conn_state;
  29. - }
  30. -
  31. - return NULL;
  32. -}
  33. -
  34. static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder,
  35. struct drm_atomic_state *state)
  36. {
  37. + struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
  38. + struct drm_connector *connector = &vc4_hdmi->connector;
  39. struct drm_connector_state *conn_state =
  40. - vc4_hdmi_encoder_get_connector_state(encoder, state);
  41. + drm_atomic_get_new_connector_state(state, connector);
  42. struct vc4_hdmi_connector_state *vc4_conn_state =
  43. conn_state_to_vc4_hdmi_conn_state(conn_state);
  44. - struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
  45. struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode;
  46. unsigned long pixel_rate = vc4_conn_state->pixel_rate;
  47. unsigned long bvb_rate, hsm_rate;