120-06-v5.18-spi-spi-mem-Kill-the-spi_mem_dtr_supports_op-helper.patch 3.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111
  1. From 2e5fba82e4aeb72d71230eef2541881615aaf7cf Mon Sep 17 00:00:00 2001
  2. From: Miquel Raynal <[email protected]>
  3. Date: Thu, 27 Jan 2022 10:18:00 +0100
  4. Subject: [PATCH 06/15] spi: spi-mem: Kill the spi_mem_dtr_supports_op() helper
  5. Now that spi_mem_default_supports_op() has access to the static
  6. controller capabilities (relating to memory operations), and now that
  7. these capabilities have been filled by the relevant controllers, there
  8. is no need for a specific helper checking only DTR operations, so let's
  9. just kill spi_mem_dtr_supports_op() and simply use
  10. spi_mem_default_supports_op() instead.
  11. Signed-off-by: Miquel Raynal <[email protected]>
  12. Reviewed-by: Pratyush Yadav <[email protected]>
  13. Reviewed-by: Boris Brezillon <[email protected]>
  14. Reviewed-by: Tudor Ambarus <[email protected]>
  15. Link: https://lore.kernel.org/linux-mtd/[email protected]
  16. (cherry picked from commit 9a15efc5d5e6b5beaed0883e5bdcd0b1384c1b20)
  17. ---
  18. drivers/spi/spi-cadence-quadspi.c | 5 +----
  19. drivers/spi/spi-mem.c | 10 ----------
  20. drivers/spi/spi-mxic.c | 10 +---------
  21. include/linux/spi/spi-mem.h | 11 -----------
  22. 4 files changed, 2 insertions(+), 34 deletions(-)
  23. --- a/drivers/spi/spi-cadence-quadspi.c
  24. +++ b/drivers/spi/spi-cadence-quadspi.c
  25. @@ -1249,10 +1249,7 @@ static bool cqspi_supports_mem_op(struct
  26. return false;
  27. }
  28. - if (all_true)
  29. - return spi_mem_dtr_supports_op(mem, op);
  30. - else
  31. - return spi_mem_default_supports_op(mem, op);
  32. + return spi_mem_default_supports_op(mem, op);
  33. }
  34. static int cqspi_of_get_flash_pdata(struct platform_device *pdev,
  35. --- a/drivers/spi/spi-mem.c
  36. +++ b/drivers/spi/spi-mem.c
  37. @@ -160,16 +160,6 @@ static bool spi_mem_check_buswidth(struc
  38. return true;
  39. }
  40. -bool spi_mem_dtr_supports_op(struct spi_mem *mem,
  41. - const struct spi_mem_op *op)
  42. -{
  43. - if (op->cmd.nbytes != 2)
  44. - return false;
  45. -
  46. - return spi_mem_check_buswidth(mem, op);
  47. -}
  48. -EXPORT_SYMBOL_GPL(spi_mem_dtr_supports_op);
  49. -
  50. bool spi_mem_default_supports_op(struct spi_mem *mem,
  51. const struct spi_mem_op *op)
  52. {
  53. --- a/drivers/spi/spi-mxic.c
  54. +++ b/drivers/spi/spi-mxic.c
  55. @@ -331,8 +331,6 @@ static int mxic_spi_data_xfer(struct mxi
  56. static bool mxic_spi_mem_supports_op(struct spi_mem *mem,
  57. const struct spi_mem_op *op)
  58. {
  59. - bool all_false;
  60. -
  61. if (op->data.buswidth > 8 || op->addr.buswidth > 8 ||
  62. op->dummy.buswidth > 8 || op->cmd.buswidth > 8)
  63. return false;
  64. @@ -344,13 +342,7 @@ static bool mxic_spi_mem_supports_op(str
  65. if (op->addr.nbytes > 7)
  66. return false;
  67. - all_false = !op->cmd.dtr && !op->addr.dtr && !op->dummy.dtr &&
  68. - !op->data.dtr;
  69. -
  70. - if (all_false)
  71. - return spi_mem_default_supports_op(mem, op);
  72. - else
  73. - return spi_mem_dtr_supports_op(mem, op);
  74. + return spi_mem_default_supports_op(mem, op);
  75. }
  76. static int mxic_spi_mem_exec_op(struct spi_mem *mem,
  77. --- a/include/linux/spi/spi-mem.h
  78. +++ b/include/linux/spi/spi-mem.h
  79. @@ -330,10 +330,6 @@ void spi_controller_dma_unmap_mem_op_dat
  80. bool spi_mem_default_supports_op(struct spi_mem *mem,
  81. const struct spi_mem_op *op);
  82. -
  83. -bool spi_mem_dtr_supports_op(struct spi_mem *mem,
  84. - const struct spi_mem_op *op);
  85. -
  86. #else
  87. static inline int
  88. spi_controller_dma_map_mem_op_data(struct spi_controller *ctlr,
  89. @@ -356,13 +352,6 @@ bool spi_mem_default_supports_op(struct
  90. {
  91. return false;
  92. }
  93. -
  94. -static inline
  95. -bool spi_mem_dtr_supports_op(struct spi_mem *mem,
  96. - const struct spi_mem_op *op)
  97. -{
  98. - return false;
  99. -}
  100. #endif /* CONFIG_SPI_MEM */
  101. int spi_mem_adjust_op_size(struct spi_mem *mem, struct spi_mem_op *op);