320-MIPS-add-support-for-buggy-MT7621S-core-detection.patch 2.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475
  1. From 6decd1aad15f56b169217789630a0098b496de0e Mon Sep 17 00:00:00 2001
  2. From: Ilya Lipnitskiy <[email protected]>
  3. Date: Wed, 7 Apr 2021 13:07:38 -0700
  4. Subject: [PATCH] MIPS: add support for buggy MT7621S core detection
  5. Most MT7621 SoCs have 2 cores, which is detected and supported properly
  6. by CPS.
  7. Unfortunately, MT7621 SoC has a less common S variant with only one core.
  8. On MT7621S, GCR_CONFIG still reports 2 cores, which leads to hangs when
  9. starting SMP. CPULAUNCH registers can be used in that case to detect the
  10. absence of the second core and override the GCR_CONFIG PCORES field.
  11. Rework a long-standing OpenWrt patch to override the value of
  12. mips_cps_numcores on single-core MT7621 systems.
  13. Tested on a dual-core MT7621 device (Ubiquiti ER-X) and a single-core
  14. MT7621 device (Netgear R6220).
  15. Original 4.14 OpenWrt patch:
  16. Link: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=4cdbc90a376dd0555201c1434a2081e055e9ceb7
  17. Current 5.10 OpenWrt patch:
  18. Link: https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ramips/patches-5.10/320-mt7621-core-detect-hack.patch;h=c63f0f4c1ec742e24d8480e80553863744b58f6a;hb=10267e17299806f9885d086147878f6c492cb904
  19. Suggested-by: Felix Fietkau <[email protected]>
  20. Signed-off-by: Ilya Lipnitskiy <[email protected]>
  21. Signed-off-by: Thomas Bogendoerfer <[email protected]>
  22. ---
  23. arch/mips/include/asm/mips-cps.h | 23 ++++++++++++++++++++++-
  24. 1 file changed, 22 insertions(+), 1 deletion(-)
  25. --- a/arch/mips/include/asm/mips-cps.h
  26. +++ b/arch/mips/include/asm/mips-cps.h
  27. @@ -11,6 +11,8 @@
  28. #include <linux/io.h>
  29. #include <linux/types.h>
  30. +#include <asm/mips-boards/launch.h>
  31. +
  32. extern unsigned long __cps_access_bad_size(void)
  33. __compiletime_error("Bad size for CPS accessor");
  34. @@ -162,12 +164,31 @@ static inline uint64_t mips_cps_cluster_
  35. */
  36. static inline unsigned int mips_cps_numcores(unsigned int cluster)
  37. {
  38. + unsigned int ncores;
  39. +
  40. if (!mips_cm_present())
  41. return 0;
  42. /* Add one before masking to handle 0xff indicating no cores */
  43. - return FIELD_GET(CM_GCR_CONFIG_PCORES,
  44. + ncores = FIELD_GET(CM_GCR_CONFIG_PCORES,
  45. mips_cps_cluster_config(cluster) + 1);
  46. +
  47. + if (IS_ENABLED(CONFIG_SOC_MT7621)) {
  48. + struct cpulaunch *launch;
  49. +
  50. + /*
  51. + * Ralink MT7621S SoC is single core, but the GCR_CONFIG method
  52. + * always reports 2 cores. Check the second core's LAUNCH_FREADY
  53. + * flag to detect if the second core is missing. This method
  54. + * only works before the core has been started.
  55. + */
  56. + launch = (struct cpulaunch *)CKSEG0ADDR(CPULAUNCH);
  57. + launch += 2; /* MT7621 has 2 VPEs per core */
  58. + if (!(launch->flags & LAUNCH_FREADY))
  59. + ncores = 1;
  60. + }
  61. +
  62. + return ncores;
  63. }
  64. /**