441-block2mtd_refresh.patch 6.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268
  1. --- a/drivers/mtd/devices/block2mtd.c
  2. +++ b/drivers/mtd/devices/block2mtd.c
  3. @@ -29,6 +29,8 @@ struct block2mtd_dev {
  4. struct block_device *blkdev;
  5. struct mtd_info mtd;
  6. struct mutex write_mutex;
  7. + rwlock_t bdev_mutex;
  8. + char devname[0];
  9. };
  10. @@ -80,6 +82,12 @@ static int block2mtd_erase(struct mtd_in
  11. size_t len = instr->len;
  12. int err;
  13. + read_lock(&dev->bdev_mutex);
  14. + if (!dev->blkdev) {
  15. + err = -EINVAL;
  16. + goto done;
  17. + }
  18. +
  19. instr->state = MTD_ERASING;
  20. mutex_lock(&dev->write_mutex);
  21. err = _block2mtd_erase(dev, from, len);
  22. @@ -91,6 +99,10 @@ static int block2mtd_erase(struct mtd_in
  23. instr->state = MTD_ERASE_DONE;
  24. mtd_erase_callback(instr);
  25. +
  26. +done:
  27. + read_unlock(&dev->bdev_mutex);
  28. +
  29. return err;
  30. }
  31. @@ -102,7 +114,13 @@ static int block2mtd_read(struct mtd_inf
  32. struct page *page;
  33. int index = from >> PAGE_SHIFT;
  34. int offset = from & (PAGE_SIZE-1);
  35. - int cpylen;
  36. + int cpylen, err = 0;
  37. +
  38. + read_lock(&dev->bdev_mutex);
  39. + if (!dev->blkdev || (from > mtd->size)) {
  40. + err = -EINVAL;
  41. + goto done;
  42. + }
  43. while (len) {
  44. if ((offset + len) > PAGE_SIZE)
  45. @@ -112,8 +130,10 @@ static int block2mtd_read(struct mtd_inf
  46. len = len - cpylen;
  47. page = page_read(dev->blkdev->bd_inode->i_mapping, index);
  48. - if (IS_ERR(page))
  49. + if (IS_ERR(page)) {
  50. return PTR_ERR(page);
  51. + goto done;
  52. + }
  53. memcpy(buf, page_address(page) + offset, cpylen);
  54. page_cache_release(page);
  55. @@ -124,7 +144,10 @@ static int block2mtd_read(struct mtd_inf
  56. offset = 0;
  57. index++;
  58. }
  59. - return 0;
  60. +
  61. +done:
  62. + read_unlock(&dev->bdev_mutex);
  63. + return err;
  64. }
  65. @@ -173,13 +196,22 @@ static int block2mtd_write(struct mtd_in
  66. size_t *retlen, const u_char *buf)
  67. {
  68. struct block2mtd_dev *dev = mtd->priv;
  69. - int err;
  70. + int err = 0;
  71. +
  72. + read_lock(&dev->bdev_mutex);
  73. + if (!dev->blkdev) {
  74. + err = -EINVAL;
  75. + goto done;
  76. + }
  77. mutex_lock(&dev->write_mutex);
  78. err = _block2mtd_write(dev, buf, to, len, retlen);
  79. mutex_unlock(&dev->write_mutex);
  80. if (err > 0)
  81. err = 0;
  82. +
  83. +done:
  84. + read_unlock(&dev->bdev_mutex);
  85. return err;
  86. }
  87. @@ -188,33 +220,110 @@ static int block2mtd_write(struct mtd_in
  88. static void block2mtd_sync(struct mtd_info *mtd)
  89. {
  90. struct block2mtd_dev *dev = mtd->priv;
  91. + read_lock(&dev->bdev_mutex);
  92. + if (dev->blkdev)
  93. sync_blockdev(dev->blkdev);
  94. + read_unlock(&dev->bdev_mutex);
  95. +
  96. return;
  97. }
  98. +static int _open_bdev(struct block2mtd_dev *dev)
  99. +{
  100. + const fmode_t mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
  101. + struct block_device *bdev;
  102. +
  103. + /* Get a handle on the device */
  104. + bdev = blkdev_get_by_path(dev->devname, mode, dev);
  105. +#ifndef MODULE
  106. + if (IS_ERR(bdev)) {
  107. + dev_t devt;
  108. +
  109. + /* We might not have rootfs mounted at this point. Try
  110. + to resolve the device name by other means. */
  111. +
  112. + devt = name_to_dev_t(dev->devname);
  113. + if (devt)
  114. + bdev = blkdev_get_by_dev(devt, mode, dev);
  115. + }
  116. +#endif
  117. +
  118. + if (IS_ERR(bdev)) {
  119. + ERROR("error: cannot open device %s", dev->devname);
  120. + return 1;
  121. + }
  122. + dev->blkdev = bdev;
  123. +
  124. + if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) {
  125. + ERROR("attempting to use an MTD device as a block device");
  126. + return 1;
  127. + }
  128. +
  129. + return 0;
  130. +}
  131. +
  132. +static void _close_bdev(struct block2mtd_dev *dev)
  133. +{
  134. + struct block_device *bdev;
  135. +
  136. + if (!dev->blkdev)
  137. + return;
  138. +
  139. + bdev = dev->blkdev;
  140. + invalidate_mapping_pages(dev->blkdev->bd_inode->i_mapping, 0, -1);
  141. + blkdev_put(dev->blkdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
  142. + dev->blkdev = NULL;
  143. +}
  144. +
  145. static void block2mtd_free_device(struct block2mtd_dev *dev)
  146. {
  147. if (!dev)
  148. return;
  149. kfree(dev->mtd.name);
  150. -
  151. - if (dev->blkdev) {
  152. - invalidate_mapping_pages(dev->blkdev->bd_inode->i_mapping,
  153. - 0, -1);
  154. - blkdev_put(dev->blkdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
  155. - }
  156. -
  157. + _close_bdev(dev);
  158. kfree(dev);
  159. }
  160. -/* FIXME: ensure that mtd->size % erase_size == 0 */
  161. -static struct block2mtd_dev *add_device(char *devname, int erase_size, const char *mtdname)
  162. +static int block2mtd_refresh(struct mtd_info *mtd)
  163. {
  164. - const fmode_t mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
  165. + struct block2mtd_dev *dev = mtd->priv;
  166. struct block_device *bdev;
  167. + dev_t devt;
  168. + int err = 0;
  169. +
  170. + /* no other mtd function can run at this point */
  171. + write_lock(&dev->bdev_mutex);
  172. +
  173. + /* get the device number for the whole disk */
  174. + devt = MKDEV(MAJOR(dev->blkdev->bd_dev), 0);
  175. +
  176. + /* close the old block device */
  177. + _close_bdev(dev);
  178. +
  179. + /* open the whole disk, issue a partition rescan, then */
  180. + bdev = blkdev_get_by_dev(devt, FMODE_WRITE | FMODE_READ, mtd);
  181. + if (!bdev || !bdev->bd_disk)
  182. + err = -EINVAL;
  183. +#ifndef CONFIG_MTD_BLOCK2MTD_MODULE
  184. + else
  185. + err = rescan_partitions(bdev->bd_disk, bdev);
  186. +#endif
  187. + if (bdev)
  188. + blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
  189. +
  190. + /* try to open the partition block device again */
  191. + _open_bdev(dev);
  192. + write_unlock(&dev->bdev_mutex);
  193. +
  194. + return err;
  195. +}
  196. +
  197. +/* FIXME: ensure that mtd->size % erase_size == 0 */
  198. +static struct block2mtd_dev *add_device(char *devname, int erase_size, char *mtdname)
  199. +{
  200. struct block2mtd_dev *dev;
  201. struct mtd_partition *part;
  202. char *name;
  203. @@ -222,36 +331,17 @@ static struct block2mtd_dev *add_device(
  204. if (!devname)
  205. return NULL;
  206. - dev = kzalloc(sizeof(struct block2mtd_dev), GFP_KERNEL);
  207. + dev = kzalloc(sizeof(struct block2mtd_dev) + strlen(devname) + 1, GFP_KERNEL);
  208. if (!dev)
  209. return NULL;
  210. - /* Get a handle on the device */
  211. - bdev = blkdev_get_by_path(devname, mode, dev);
  212. -#ifndef MODULE
  213. - if (IS_ERR(bdev)) {
  214. + strcpy(dev->devname, devname);
  215. - /* We might not have rootfs mounted at this point. Try
  216. - to resolve the device name by other means. */
  217. -
  218. - dev_t devt = name_to_dev_t(devname);
  219. - if (devt)
  220. - bdev = blkdev_get_by_dev(devt, mode, dev);
  221. - }
  222. -#endif
  223. -
  224. - if (IS_ERR(bdev)) {
  225. - ERROR("error: cannot open device %s", devname);
  226. - goto devinit_err;
  227. - }
  228. - dev->blkdev = bdev;
  229. -
  230. - if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) {
  231. - ERROR("attempting to use an MTD device as a block device");
  232. + if (_open_bdev(dev))
  233. goto devinit_err;
  234. - }
  235. mutex_init(&dev->write_mutex);
  236. + rwlock_init(&dev->bdev_mutex);
  237. /* Setup the MTD structure */
  238. /* make the name contain the block device in */
  239. @@ -276,6 +366,7 @@ static struct block2mtd_dev *add_device(
  240. dev->mtd._read = block2mtd_read;
  241. dev->mtd.priv = dev;
  242. dev->mtd.owner = THIS_MODULE;
  243. + dev->mtd.refresh_device = block2mtd_refresh;
  244. part = kzalloc(sizeof(struct mtd_partition), GFP_KERNEL);
  245. part->name = name;