169-media-atmel-atmel-isc-add-HIS-to-register-offsets.patch 4.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110
  1. From 8c19aa14b8303a0e7c4bae42f3f00f9a2a65b0db Mon Sep 17 00:00:00 2001
  2. From: Eugen Hristev <[email protected]>
  3. Date: Tue, 13 Apr 2021 12:57:11 +0200
  4. Subject: [PATCH 169/247] media: atmel: atmel-isc: add HIS to register offsets
  5. The HIS submodule is a part of the atmel-isc pipeline, and stands for
  6. Histogram. This module performs a color histogram that can be read and used
  7. by the main processor.
  8. Add his to the reg offsets struct.
  9. This will allow different products to have a different reg offset for this
  10. particular module.
  11. Signed-off-by: Eugen Hristev <[email protected]>
  12. Signed-off-by: Hans Verkuil <[email protected]>
  13. Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  14. ---
  15. drivers/media/platform/atmel/atmel-isc-base.c | 11 +++++++----
  16. drivers/media/platform/atmel/atmel-isc-regs.h | 2 ++
  17. drivers/media/platform/atmel/atmel-isc.h | 2 ++
  18. drivers/media/platform/atmel/atmel-sama5d2-isc.c | 1 +
  19. 4 files changed, 12 insertions(+), 4 deletions(-)
  20. diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c
  21. index 25c90b821067..5c95aa45cf6c 100644
  22. --- a/drivers/media/platform/atmel/atmel-isc-base.c
  23. +++ b/drivers/media/platform/atmel/atmel-isc-base.c
  24. @@ -686,12 +686,13 @@ static void isc_set_histogram(struct isc_device *isc, bool enable)
  25. struct isc_ctrls *ctrls = &isc->ctrls;
  26. if (enable) {
  27. - regmap_write(regmap, ISC_HIS_CFG,
  28. + regmap_write(regmap, ISC_HIS_CFG + isc->offsets.his,
  29. ISC_HIS_CFG_MODE_GR |
  30. (isc->config.sd_format->cfa_baycfg
  31. << ISC_HIS_CFG_BAYSEL_SHIFT) |
  32. ISC_HIS_CFG_RAR);
  33. - regmap_write(regmap, ISC_HIS_CTRL, ISC_HIS_CTRL_EN);
  34. + regmap_write(regmap, ISC_HIS_CTRL + isc->offsets.his,
  35. + ISC_HIS_CTRL_EN);
  36. regmap_write(regmap, ISC_INTEN, ISC_INT_HISDONE);
  37. ctrls->hist_id = ISC_HIS_CFG_MODE_GR;
  38. isc_update_profile(isc);
  39. @@ -700,7 +701,8 @@ static void isc_set_histogram(struct isc_device *isc, bool enable)
  40. ctrls->hist_stat = HIST_ENABLED;
  41. } else {
  42. regmap_write(regmap, ISC_INTDIS, ISC_INT_HISDONE);
  43. - regmap_write(regmap, ISC_HIS_CTRL, ISC_HIS_CTRL_DIS);
  44. + regmap_write(regmap, ISC_HIS_CTRL + isc->offsets.his,
  45. + ISC_HIS_CTRL_DIS);
  46. ctrls->hist_stat = HIST_DISABLED;
  47. }
  48. @@ -1836,7 +1838,8 @@ static void isc_awb_work(struct work_struct *w)
  49. ctrls->awb = ISC_WB_NONE;
  50. }
  51. }
  52. - regmap_write(regmap, ISC_HIS_CFG, hist_id | baysel | ISC_HIS_CFG_RAR);
  53. + regmap_write(regmap, ISC_HIS_CFG + isc->offsets.his,
  54. + hist_id | baysel | ISC_HIS_CFG_RAR);
  55. isc_update_profile(isc);
  56. /* if awb has been disabled, we don't need to start another histogram */
  57. if (ctrls->awb)
  58. diff --git a/drivers/media/platform/atmel/atmel-isc-regs.h b/drivers/media/platform/atmel/atmel-isc-regs.h
  59. index 2205484e04fc..0ab280ab59ec 100644
  60. --- a/drivers/media/platform/atmel/atmel-isc-regs.h
  61. +++ b/drivers/media/platform/atmel/atmel-isc-regs.h
  62. @@ -224,6 +224,8 @@
  63. #define ISC_RLP_CFG_MODE_YYCC_LIMITED 0xc
  64. #define ISC_RLP_CFG_MODE_MASK GENMASK(3, 0)
  65. +/* Offset for HIS register specific to sama5d2 product */
  66. +#define ISC_SAMA5D2_HIS_OFFSET 0
  67. /* Histogram Control Register */
  68. #define ISC_HIS_CTRL 0x000003d4
  69. diff --git a/drivers/media/platform/atmel/atmel-isc.h b/drivers/media/platform/atmel/atmel-isc.h
  70. index 4a5293c66f49..97ec4c58297e 100644
  71. --- a/drivers/media/platform/atmel/atmel-isc.h
  72. +++ b/drivers/media/platform/atmel/atmel-isc.h
  73. @@ -150,6 +150,7 @@ struct isc_ctrls {
  74. * @sub422: Offset for the SUB422 register
  75. * @sub420: Offset for the SUB420 register
  76. * @rlp: Offset for the RLP register
  77. + * @his: Offset for the HIS related registers
  78. */
  79. struct isc_reg_offsets {
  80. u32 csc;
  81. @@ -157,6 +158,7 @@ struct isc_reg_offsets {
  82. u32 sub422;
  83. u32 sub420;
  84. u32 rlp;
  85. + u32 his;
  86. };
  87. /*
  88. diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
  89. index b01b5b9f229b..db93cb76c08b 100644
  90. --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
  91. +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
  92. @@ -256,6 +256,7 @@ static int atmel_isc_probe(struct platform_device *pdev)
  93. isc->offsets.sub422 = ISC_SAMA5D2_SUB422_OFFSET;
  94. isc->offsets.sub420 = ISC_SAMA5D2_SUB420_OFFSET;
  95. isc->offsets.rlp = ISC_SAMA5D2_RLP_OFFSET;
  96. + isc->offsets.his = ISC_SAMA5D2_HIS_OFFSET;
  97. /* sama5d2-isc - 8 bits per beat */
  98. isc->dcfg = ISC_DCFG_YMBSIZE_BEATS8 | ISC_DCFG_CMBSIZE_BEATS8;
  99. --
  100. 2.32.0