176-media-atmel-atmel-isc-create-product-specific-v4l2-c.patch 3.6 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495
  1. From 0a75c502eac4f2ef71b6c3e0b3a01db1b3c37ba9 Mon Sep 17 00:00:00 2001
  2. From: Eugen Hristev <[email protected]>
  3. Date: Tue, 13 Apr 2021 12:57:18 +0200
  4. Subject: [PATCH 176/247] media: atmel: atmel-isc: create product specific v4l2
  5. controls config
  6. Create product specific callback for initializing v4l2 controls.
  7. Call this from v4l2 controls init function.
  8. [hverkuil: made isc_sama5d2_config_ctrls static]
  9. Signed-off-by: Eugen Hristev <[email protected]>
  10. Signed-off-by: Hans Verkuil <[email protected]>
  11. Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  12. ---
  13. drivers/media/platform/atmel/atmel-isc-base.c | 5 +++--
  14. drivers/media/platform/atmel/atmel-isc.h | 5 +++++
  15. drivers/media/platform/atmel/atmel-sama5d2-isc.c | 12 ++++++++++++
  16. 3 files changed, 20 insertions(+), 2 deletions(-)
  17. diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c
  18. index ffce8de2cf4d..8ed8b8a4840c 100644
  19. --- a/drivers/media/platform/atmel/atmel-isc-base.c
  20. +++ b/drivers/media/platform/atmel/atmel-isc-base.c
  21. @@ -2051,11 +2051,12 @@ static int isc_ctrl_init(struct isc_device *isc)
  22. if (ret < 0)
  23. return ret;
  24. + /* Initialize product specific controls. For example, contrast */
  25. + isc->config_ctrls(isc, ops);
  26. +
  27. ctrls->brightness = 0;
  28. - ctrls->contrast = 256;
  29. v4l2_ctrl_new_std(hdl, ops, V4L2_CID_BRIGHTNESS, -1024, 1023, 1, 0);
  30. - v4l2_ctrl_new_std(hdl, ops, V4L2_CID_CONTRAST, -2048, 2047, 1, 256);
  31. v4l2_ctrl_new_std(hdl, ops, V4L2_CID_GAMMA, 0, isc->gamma_max, 1,
  32. isc->gamma_max);
  33. isc->awb_ctrl = v4l2_ctrl_new_std(hdl, &isc_awb_ops,
  34. diff --git a/drivers/media/platform/atmel/atmel-isc.h b/drivers/media/platform/atmel/atmel-isc.h
  35. index 293746664cef..428419d5a07d 100644
  36. --- a/drivers/media/platform/atmel/atmel-isc.h
  37. +++ b/drivers/media/platform/atmel/atmel-isc.h
  38. @@ -226,6 +226,8 @@ struct isc_reg_offsets {
  39. * specific CBC module
  40. * @config_cc: pointer to a function that initializes product
  41. * specific CC module
  42. + * @config_ctrls: pointer to a functoin that initializes product
  43. + * specific v4l2 controls.
  44. *
  45. * @offsets: struct holding the product specific register offsets
  46. */
  47. @@ -300,6 +302,9 @@ struct isc_device {
  48. void (*config_csc)(struct isc_device *isc);
  49. void (*config_cbc)(struct isc_device *isc);
  50. void (*config_cc)(struct isc_device *isc);
  51. +
  52. + void (*config_ctrls)(struct isc_device *isc,
  53. + const struct v4l2_ctrl_ops *ops);
  54. };
  55. struct isc_reg_offsets offsets;
  56. diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
  57. index 903920b74965..7512012cd9f3 100644
  58. --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
  59. +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
  60. @@ -96,6 +96,17 @@ static void isc_sama5d2_config_cc(struct isc_device *isc)
  61. regmap_write(regmap, ISC_CC_BB_OB, (1 << 8));
  62. }
  63. +static void isc_sama5d2_config_ctrls(struct isc_device *isc,
  64. + const struct v4l2_ctrl_ops *ops)
  65. +{
  66. + struct isc_ctrls *ctrls = &isc->ctrls;
  67. + struct v4l2_ctrl_handler *hdl = &ctrls->handler;
  68. +
  69. + ctrls->contrast = 256;
  70. +
  71. + v4l2_ctrl_new_std(hdl, ops, V4L2_CID_CONTRAST, -2048, 2047, 1, 256);
  72. +}
  73. +
  74. /* Gamma table with gamma 1/2.2 */
  75. static const u32 isc_sama5d2_gamma_table[][GAMMA_ENTRIES] = {
  76. /* 0 --> gamma 1/1.8 */
  77. @@ -265,6 +276,7 @@ static int atmel_isc_probe(struct platform_device *pdev)
  78. isc->config_csc = isc_sama5d2_config_csc;
  79. isc->config_cbc = isc_sama5d2_config_cbc;
  80. isc->config_cc = isc_sama5d2_config_cc;
  81. + isc->config_ctrls = isc_sama5d2_config_ctrls;
  82. isc->offsets.csc = ISC_SAMA5D2_CSC_OFFSET;
  83. isc->offsets.cbc = ISC_SAMA5D2_CBC_OFFSET;
  84. --
  85. 2.32.0