1234567891011121314151617181920212223242526272829303132333435363738394041 |
- From e53725fe0c7e6b52927280272f49fe5f4b4ef317 Mon Sep 17 00:00:00 2001
- From: Pierre-Louis Bossart <[email protected]>
- Date: Fri, 26 Mar 2021 16:59:13 -0500
- Subject: [PATCH 187/247] ASoC: atmel: atmel-i2s: remove useless initialization
- Cppcheck complains:
- sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]
- err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
- ^
- sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized
- int err = -ENXIO;
- ^
- sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten
- err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
- ^
- Signed-off-by: Pierre-Louis Bossart <[email protected]>
- Reviewed-by: Codrin Ciubotariu <[email protected]>
- Link: https://lore.kernel.org/r/[email protected]
- Signed-off-by: Mark Brown <[email protected]>
- ---
- sound/soc/atmel/atmel-i2s.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
- diff --git a/sound/soc/atmel/atmel-i2s.c b/sound/soc/atmel/atmel-i2s.c
- index 7483c474ccd7..e7169c63becd 100644
- --- a/sound/soc/atmel/atmel-i2s.c
- +++ b/sound/soc/atmel/atmel-i2s.c
- @@ -613,7 +613,7 @@ static int atmel_i2s_probe(struct platform_device *pdev)
- struct regmap *regmap;
- void __iomem *base;
- int irq;
- - int err = -ENXIO;
- + int err;
- unsigned int pcm_flags = 0;
- unsigned int version;
-
- --
- 2.32.0
|