| 12345678910111213141516171819202122232425262728293031323334353637383940414243444546 |
- From 40350ce3ae8701146aafd79c5f7b5582d9955e58 Mon Sep 17 00:00:00 2001
- From: Daniel Golle <[email protected]>
- Date: Sun, 25 Sep 2022 15:12:35 +0100
- Subject: [PATCH 1/2] net: ethernet: mtk_eth_soc: fix wrong use of new helper
- function
- To: [email protected],
- [email protected],
- Lorenzo Bianconi <[email protected]>
- Cc: Sujuan Chen <[email protected]>,
- Bo Jiao <[email protected]>,
- Felix Fietkau <[email protected]>,
- John Crispin <[email protected]>,
- Sean Wang <[email protected]>,
- Mark Lee <[email protected]>,
- David S. Miller <[email protected]>,
- Eric Dumazet <[email protected]>,
- Jakub Kicinski <[email protected]>,
- Paolo Abeni <[email protected]>,
- Matthias Brugger <[email protected]>,
- Chen Minqiang <[email protected]>
- In function mtk_foe_entry_set_vlan() the call to field accessor macro
- FIELD_GET(MTK_FOE_IB1_BIND_VLAN_LAYER, entry->ib1)
- has been wrongly replaced by
- mtk_prep_ib1_vlan_layer(eth, entry->ib1)
- Use correct helper function mtk_get_ib1_vlan_layer instead.
- Reported-by: Chen Minqiang <[email protected]>
- Fixes: 03a3180e5c09e1 ("net: ethernet: mtk_eth_soc: introduce flow offloading support for mt7986")
- Signed-off-by: Daniel Golle <[email protected]>
- ---
- drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
- --- a/drivers/net/ethernet/mediatek/mtk_ppe.c
- +++ b/drivers/net/ethernet/mediatek/mtk_ppe.c
- @@ -337,7 +337,7 @@ int mtk_foe_entry_set_vlan(struct mtk_et
- {
- struct mtk_foe_mac_info *l2 = mtk_foe_entry_l2(eth, entry);
-
- - switch (mtk_prep_ib1_vlan_layer(eth, entry->ib1)) {
- + switch (mtk_get_ib1_vlan_layer(eth, entry->ib1)) {
- case 0:
- entry->ib1 |= mtk_get_ib1_vlan_tag_mask(eth) |
- mtk_prep_ib1_vlan_layer(eth, 1);
|
