303-v4.15-0006-brcmfmac-get-rid-of-struct-brcmf_cfg80211_info-activ.patch 3.3 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586
  1. From bbf35414cd23a9d7230bfd7046e1e2c26020e7eb Mon Sep 17 00:00:00 2001
  2. From: Arend Van Spriel <[email protected]>
  3. Date: Wed, 8 Nov 2017 14:36:36 +0100
  4. Subject: [PATCH] brcmfmac: get rid of struct brcmf_cfg80211_info::active_scan
  5. field
  6. The field struct brcmf_cfg80211_info::active_scan is set to true upon
  7. initializing the driver instance, but it is never changed so simply
  8. get rid of it.
  9. Reviewed-by: Hante Meuleman <[email protected]>
  10. Reviewed-by: Pieter-Paul Giesberts <[email protected]>
  11. Reviewed-by: Franky Lin <[email protected]>
  12. Signed-off-by: Arend van Spriel <[email protected]>
  13. Signed-off-by: Kalle Valo <[email protected]>
  14. ---
  15. drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 +---------
  16. drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h | 2 --
  17. drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 5 +----
  18. 3 files changed, 2 insertions(+), 15 deletions(-)
  19. --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
  20. +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
  21. @@ -1043,7 +1043,6 @@ brcmf_do_escan(struct brcmf_if *ifp, str
  22. {
  23. struct brcmf_cfg80211_info *cfg = ifp->drvr->config;
  24. s32 err;
  25. - u32 passive_scan;
  26. struct brcmf_scan_results *results;
  27. struct escan_info *escan = &cfg->escan_info;
  28. @@ -1051,13 +1050,7 @@ brcmf_do_escan(struct brcmf_if *ifp, str
  29. escan->ifp = ifp;
  30. escan->wiphy = cfg->wiphy;
  31. escan->escan_state = WL_ESCAN_STATE_SCANNING;
  32. - passive_scan = cfg->active_scan ? 0 : 1;
  33. - err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_PASSIVE_SCAN,
  34. - passive_scan);
  35. - if (err) {
  36. - brcmf_err("error (%d)\n", err);
  37. - return err;
  38. - }
  39. +
  40. brcmf_scan_config_mpc(ifp, 0);
  41. results = (struct brcmf_scan_results *)cfg->escan_info.escan_buf;
  42. results->version = 0;
  43. @@ -5767,7 +5760,6 @@ static s32 wl_init_priv(struct brcmf_cfg
  44. cfg->scan_request = NULL;
  45. cfg->pwr_save = true;
  46. - cfg->active_scan = true; /* we do active scan per default */
  47. cfg->dongle_up = false; /* dongle is not up yet */
  48. err = brcmf_init_priv_mem(cfg);
  49. if (err)
  50. --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h
  51. +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h
  52. @@ -283,7 +283,6 @@ struct brcmf_cfg80211_wowl {
  53. * @scan_status: scan activity on the dongle.
  54. * @pub: common driver information.
  55. * @channel: current channel.
  56. - * @active_scan: current scan mode.
  57. * @int_escan_map: bucket map for which internal e-scan is done.
  58. * @ibss_starter: indicates this sta is ibss starter.
  59. * @pwr_save: indicate whether dongle to support power save mode.
  60. @@ -316,7 +315,6 @@ struct brcmf_cfg80211_info {
  61. unsigned long scan_status;
  62. struct brcmf_pub *pub;
  63. u32 channel;
  64. - bool active_scan;
  65. u32 int_escan_map;
  66. bool ibss_starter;
  67. bool pwr_save;
  68. --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
  69. +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
  70. @@ -692,10 +692,7 @@ static s32 brcmf_p2p_escan(struct brcmf_
  71. /* determine the scan engine parameters */
  72. sparams->bss_type = DOT11_BSSTYPE_ANY;
  73. - if (p2p->cfg->active_scan)
  74. - sparams->scan_type = 0;
  75. - else
  76. - sparams->scan_type = 1;
  77. + sparams->scan_type = BRCMF_SCANTYPE_ACTIVE;
  78. eth_broadcast_addr(sparams->bssid);
  79. sparams->home_time = cpu_to_le32(P2PAPI_SCAN_HOME_TIME_MS);