312-v4.16-0003-brcmfmac-Clarify-if-using-braces.patch 1.1 KB

123456789101112131415161718192021222324252627282930313233343536
  1. From a7323378dcf1f10a98f47b744e6f65e6fd671d84 Mon Sep 17 00:00:00 2001
  2. From: Ian Molton <[email protected]>
  3. Date: Fri, 8 Dec 2017 13:10:28 +0100
  4. Subject: [PATCH] brcmfmac: Clarify if using braces.
  5. Whilst this if () statement is technically correct, it lacks clarity.
  6. Signed-off-by: Ian Molton <[email protected]>
  7. Signed-off-by: Arend van Spriel <[email protected]>
  8. Signed-off-by: Kalle Valo <[email protected]>
  9. ---
  10. drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 +++--
  11. 1 file changed, 3 insertions(+), 2 deletions(-)
  12. --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
  13. +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
  14. @@ -746,16 +746,17 @@ int brcmf_sdiod_send_pkt(struct brcmf_sd
  15. if (err)
  16. return err;
  17. - if (pktq->qlen == 1 || !sdiodev->sg_support)
  18. + if (pktq->qlen == 1 || !sdiodev->sg_support) {
  19. skb_queue_walk(pktq, skb) {
  20. err = brcmf_sdiod_buff_write(sdiodev, SDIO_FUNC_2,
  21. addr, skb);
  22. if (err)
  23. break;
  24. }
  25. - else
  26. + } else {
  27. err = brcmf_sdiod_sglist_rw(sdiodev, SDIO_FUNC_2, true, addr,
  28. pktq);
  29. + }
  30. return err;
  31. }