802-can-0008-can-flexcan-flexcan_irq_state-only-read-timestamp-if.patch 1.2 KB

1234567891011121314151617181920212223242526272829303132333435363738
  1. From 1a92e5a9109963e2491eec111b84b35b4e2adc8f Mon Sep 17 00:00:00 2001
  2. From: Marc Kleine-Budde <[email protected]>
  3. Date: Wed, 9 Oct 2019 15:15:37 +0200
  4. Subject: [PATCH] can: flexcan: flexcan_irq_state(): only read timestamp if
  5. needed
  6. The function flexcan_irq_state() checks the controller for CAN state
  7. changes and pushes a skb with the new state and a timestamp into the
  8. rx-offload framework.
  9. This patch optimizes the function by only reading the timestamp, if a
  10. state change is detected.
  11. Signed-off-by: Marc Kleine-Budde <[email protected]>
  12. ---
  13. drivers/net/can/flexcan.c | 4 ++--
  14. 1 file changed, 2 insertions(+), 2 deletions(-)
  15. --- a/drivers/net/can/flexcan.c
  16. +++ b/drivers/net/can/flexcan.c
  17. @@ -751,8 +751,6 @@ static void flexcan_irq_state(struct net
  18. u32 timestamp;
  19. int err;
  20. - timestamp = priv->read(&regs->timer) << 16;
  21. -
  22. flt = reg_esr & FLEXCAN_ESR_FLT_CONF_MASK;
  23. if (likely(flt == FLEXCAN_ESR_FLT_CONF_ACTIVE)) {
  24. tx_state = unlikely(reg_esr & FLEXCAN_ESR_TX_WRN) ?
  25. @@ -772,6 +770,8 @@ static void flexcan_irq_state(struct net
  26. if (likely(new_state == priv->can.state))
  27. return;
  28. + timestamp = priv->read(&regs->timer) << 16;
  29. +
  30. skb = alloc_can_err_skb(dev, &cf);
  31. if (unlikely(!skb))
  32. return;