2
0

329-ath9k-clean-up-debugfs-print-of-reset-causes.patch 2.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869
  1. From: Felix Fietkau <[email protected]>
  2. Date: Sat, 18 Oct 2014 13:36:41 +0200
  3. Subject: [PATCH] ath9k: clean up debugfs print of reset causes
  4. Reduce code duplication
  5. Signed-off-by: Felix Fietkau <[email protected]>
  6. ---
  7. --- a/drivers/net/wireless/ath/ath9k/debug.c
  8. +++ b/drivers/net/wireless/ath/ath9k/debug.c
  9. @@ -852,36 +852,30 @@ static ssize_t read_file_reset(struct fi
  10. size_t count, loff_t *ppos)
  11. {
  12. struct ath_softc *sc = file->private_data;
  13. + static const char * const reset_cause[__RESET_TYPE_MAX] = {
  14. + [RESET_TYPE_BB_HANG] = "Baseband Hang",
  15. + [RESET_TYPE_BB_WATCHDOG] = "Baseband Watchdog",
  16. + [RESET_TYPE_FATAL_INT] = "Fatal HW Error",
  17. + [RESET_TYPE_TX_ERROR] = "TX HW error",
  18. + [RESET_TYPE_TX_GTT] = "Transmit timeout",
  19. + [RESET_TYPE_TX_HANG] = "TX Path Hang",
  20. + [RESET_TYPE_PLL_HANG] = "PLL RX Hang",
  21. + [RESET_TYPE_MAC_HANG] = "MAC Hang",
  22. + [RESET_TYPE_BEACON_STUCK] = "Stuck Beacon",
  23. + [RESET_TYPE_MCI] = "MCI Reset",
  24. + };
  25. char buf[512];
  26. unsigned int len = 0;
  27. + int i;
  28. - len += scnprintf(buf + len, sizeof(buf) - len,
  29. - "%17s: %2d\n", "Baseband Hang",
  30. - sc->debug.stats.reset[RESET_TYPE_BB_HANG]);
  31. - len += scnprintf(buf + len, sizeof(buf) - len,
  32. - "%17s: %2d\n", "Baseband Watchdog",
  33. - sc->debug.stats.reset[RESET_TYPE_BB_WATCHDOG]);
  34. - len += scnprintf(buf + len, sizeof(buf) - len,
  35. - "%17s: %2d\n", "Fatal HW Error",
  36. - sc->debug.stats.reset[RESET_TYPE_FATAL_INT]);
  37. - len += scnprintf(buf + len, sizeof(buf) - len,
  38. - "%17s: %2d\n", "TX HW error",
  39. - sc->debug.stats.reset[RESET_TYPE_TX_ERROR]);
  40. - len += scnprintf(buf + len, sizeof(buf) - len,
  41. - "%17s: %2d\n", "TX Path Hang",
  42. - sc->debug.stats.reset[RESET_TYPE_TX_HANG]);
  43. - len += scnprintf(buf + len, sizeof(buf) - len,
  44. - "%17s: %2d\n", "PLL RX Hang",
  45. - sc->debug.stats.reset[RESET_TYPE_PLL_HANG]);
  46. - len += scnprintf(buf + len, sizeof(buf) - len,
  47. - "%17s: %2d\n", "MAC Hang",
  48. - sc->debug.stats.reset[RESET_TYPE_MAC_HANG]);
  49. - len += scnprintf(buf + len, sizeof(buf) - len,
  50. - "%17s: %2d\n", "Stuck Beacon",
  51. - sc->debug.stats.reset[RESET_TYPE_BEACON_STUCK]);
  52. - len += scnprintf(buf + len, sizeof(buf) - len,
  53. - "%17s: %2d\n", "MCI Reset",
  54. - sc->debug.stats.reset[RESET_TYPE_MCI]);
  55. + for (i = 0; i < ARRAY_SIZE(reset_cause); i++) {
  56. + if (!reset_cause[i])
  57. + continue;
  58. +
  59. + len += scnprintf(buf + len, sizeof(buf) - len,
  60. + "%17s: %2d\n", reset_cause[i],
  61. + sc->debug.stats.reset[i]);
  62. + }
  63. if (len > sizeof(buf))
  64. len = sizeof(buf);