704-02-v5.17-net-mtk_eth_soc-remove-interface-checks-in-mtk_valid.patch 2.7 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475
  1. From db81ca153814475d7e07365d46a4d1134bd122e2 Mon Sep 17 00:00:00 2001
  2. From: "Russell King (Oracle)" <[email protected]>
  3. Date: Tue, 16 Nov 2021 10:06:48 +0000
  4. Subject: [PATCH] net: mtk_eth_soc: remove interface checks in mtk_validate()
  5. As phylink checks the interface mode against the supported_interfaces
  6. bitmap, we no longer need to validate the interface mode, nor handle
  7. PHY_INTERFACE_MODE_NA in the validation function. Remove these to
  8. simplify the implementation.
  9. Signed-off-by: Russell King (Oracle) <[email protected]>
  10. Signed-off-by: David S. Miller <[email protected]>
  11. ---
  12. drivers/net/ethernet/mediatek/mtk_eth_soc.c | 34 ---------------------
  13. 1 file changed, 34 deletions(-)
  14. --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
  15. +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
  16. @@ -577,24 +577,8 @@ static void mtk_validate(struct phylink_
  17. unsigned long *supported,
  18. struct phylink_link_state *state)
  19. {
  20. - struct mtk_mac *mac = container_of(config, struct mtk_mac,
  21. - phylink_config);
  22. __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
  23. - if (state->interface != PHY_INTERFACE_MODE_NA &&
  24. - state->interface != PHY_INTERFACE_MODE_MII &&
  25. - state->interface != PHY_INTERFACE_MODE_GMII &&
  26. - !(MTK_HAS_CAPS(mac->hw->soc->caps, MTK_RGMII) &&
  27. - phy_interface_mode_is_rgmii(state->interface)) &&
  28. - !(MTK_HAS_CAPS(mac->hw->soc->caps, MTK_TRGMII) &&
  29. - !mac->id && state->interface == PHY_INTERFACE_MODE_TRGMII) &&
  30. - !(MTK_HAS_CAPS(mac->hw->soc->caps, MTK_SGMII) &&
  31. - (state->interface == PHY_INTERFACE_MODE_SGMII ||
  32. - phy_interface_mode_is_8023z(state->interface)))) {
  33. - linkmode_zero(supported);
  34. - return;
  35. - }
  36. -
  37. phylink_set_port_modes(mask);
  38. phylink_set(mask, Autoneg);
  39. @@ -621,7 +605,6 @@ static void mtk_validate(struct phylink_
  40. case PHY_INTERFACE_MODE_MII:
  41. case PHY_INTERFACE_MODE_RMII:
  42. case PHY_INTERFACE_MODE_REVMII:
  43. - case PHY_INTERFACE_MODE_NA:
  44. default:
  45. phylink_set(mask, 10baseT_Half);
  46. phylink_set(mask, 10baseT_Full);
  47. @@ -630,23 +613,6 @@ static void mtk_validate(struct phylink_
  48. break;
  49. }
  50. - if (state->interface == PHY_INTERFACE_MODE_NA) {
  51. - if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_SGMII)) {
  52. - phylink_set(mask, 1000baseT_Full);
  53. - phylink_set(mask, 1000baseX_Full);
  54. - phylink_set(mask, 2500baseX_Full);
  55. - }
  56. - if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_RGMII)) {
  57. - phylink_set(mask, 1000baseT_Full);
  58. - phylink_set(mask, 1000baseT_Half);
  59. - phylink_set(mask, 1000baseX_Full);
  60. - }
  61. - if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_GEPHY)) {
  62. - phylink_set(mask, 1000baseT_Full);
  63. - phylink_set(mask, 1000baseT_Half);
  64. - }
  65. - }
  66. -
  67. phylink_set(mask, Pause);
  68. phylink_set(mask, Asym_Pause);