701-v6.2-0001-net-dpaa2-eth-don-t-use-ENOTSUPP-error-code.patch 1.7 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344
  1. From f3763a0c1b07273218cbf5886bdf8df9df501111 Mon Sep 17 00:00:00 2001
  2. From: Vladimir Oltean <[email protected]>
  3. Date: Tue, 29 Nov 2022 16:12:10 +0200
  4. Subject: [PATCH 03/14] net: dpaa2-eth: don't use -ENOTSUPP error code
  5. dpaa2_eth_setup_dpni() is called from the probe path and
  6. dpaa2_eth_set_link_ksettings() is propagated to user space.
  7. include/linux/errno.h says that ENOTSUPP is "Defined for the NFSv3
  8. protocol". Conventional wisdom has it to not use it in networking
  9. drivers. Replace it with -EOPNOTSUPP.
  10. Signed-off-by: Vladimir Oltean <[email protected]>
  11. Reviewed-by: Andrew Lunn <[email protected]>
  12. Reviewed-by: Ioana Ciornei <[email protected]>
  13. Tested-by: Ioana Ciornei <[email protected]>
  14. Signed-off-by: Paolo Abeni <[email protected]>
  15. ---
  16. drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +-
  17. drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 2 +-
  18. 2 files changed, 2 insertions(+), 2 deletions(-)
  19. --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
  20. +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
  21. @@ -3614,7 +3614,7 @@ static int dpaa2_eth_setup_dpni(struct f
  22. dev_err(dev, "DPNI version %u.%u not supported, need >= %u.%u\n",
  23. priv->dpni_ver_major, priv->dpni_ver_minor,
  24. DPNI_VER_MAJOR, DPNI_VER_MINOR);
  25. - err = -ENOTSUPP;
  26. + err = -EOPNOTSUPP;
  27. goto close;
  28. }
  29. --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c
  30. +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c
  31. @@ -118,7 +118,7 @@ dpaa2_eth_set_link_ksettings(struct net_
  32. struct dpaa2_eth_priv *priv = netdev_priv(net_dev);
  33. if (!dpaa2_eth_is_type_phy(priv))
  34. - return -ENOTSUPP;
  35. + return -EOPNOTSUPP;
  36. return phylink_ethtool_ksettings_set(priv->mac->phylink, link_settings);
  37. }