Browse Source

taildrop: fix defer in loop (#13757)

However, this affects the scope of a defer.

Updates #11038

Signed-off-by: Joe Tsai <[email protected]>
Joe Tsai 1 year ago
parent
commit
52ef27ab7c
1 changed files with 1 additions and 1 deletions
  1. 1 1
      taildrop/taildrop.go

+ 1 - 1
taildrop/taildrop.go

@@ -228,7 +228,6 @@ func (m *Manager) IncomingFiles() []ipn.PartialFile {
 	files := make([]ipn.PartialFile, 0)
 	for k, f := range m.incomingFiles.All() {
 		f.mu.Lock()
-		defer f.mu.Unlock()
 		files = append(files, ipn.PartialFile{
 			Name:         k.name,
 			Started:      f.started,
@@ -238,6 +237,7 @@ func (m *Manager) IncomingFiles() []ipn.PartialFile {
 			FinalPath:    f.finalPath,
 			Done:         f.done,
 		})
+		f.mu.Unlock()
 	}
 	return files
 }