all: close fake userspace engines when tests complete

We were leaking FDs.
In a few places, switch from defer to t.Cleanup.

Signed-off-by: Josh Bleecher Snyder <[email protected]>

ipn/ipnlocal/local_test.go

@@ -443,6 +443,7 @@ func TestLazyMachineKeyGeneration(t *testing.T) {
 	if err != nil {
 		t.Fatalf("NewFakeUserspaceEngine: %v", err)
 	}
+	t.Cleanup(eng.Close)
 	lb, err := NewLocalBackend(logf, "logid", store, eng)
 	if err != nil {
 		t.Fatalf("NewLocalBackend: %v", err)

ipn/ipnlocal/loglines_test.go

@@ -52,6 +52,7 @@ func TestLocalLogLines(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	t.Cleanup(e.Close)
 
 	lb, err := NewLocalBackend(logf, idA.String(), store, e)
 	if err != nil {

ipn/ipnlocal/state_test.go

@@ -284,6 +284,7 @@ func TestStateMachine(t *testing.T) {
 	if err != nil {
 		t.Fatalf("NewFakeUserspaceEngine: %v", err)
 	}
+	t.Cleanup(e.Close)
 
 	cc := newMockControl()
 	b, err := NewLocalBackend(logf, "logid", store, e)

ipn/ipnserver/server_test.go

@@ -60,7 +60,7 @@ func TestRunMultipleAccepts(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer eng.Close()
+	t.Cleanup(eng.Close)
 
 	opts := ipnserver.Options{
 		SocketPath: socketPath,

wgengine/userspace_test.go

@@ -89,7 +89,7 @@ func TestUserspaceEngineReconfig(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer e.Close()
+	t.Cleanup(e.Close)
 	ue := e.(*userspaceEngine)
 
 	routerCfg := &router.Config{}
@@ -158,7 +158,7 @@ func TestUserspaceEnginePortReconfig(t *testing.T) {
 	if ue == nil {
 		t.Fatal("could not create a wgengine with a specific port")
 	}
-	defer ue.Close()
+	t.Cleanup(ue.Close)
 
 	startingPort := ue.magicConn.LocalPort()
 	nodeKey := nkFromHex("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")

wgengine/watchdog_test.go

@@ -48,6 +48,7 @@ func TestWatchdog(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
+		t.Cleanup(e.Close)
 		usEngine := e.(*userspaceEngine)
 		e = NewWatchdog(e)
 		wdEngine := e.(*watchdogEngine)