Kaynağa Gözat

net/ping: fix ICMP echo code field to 0

The code was trying to pass the ICMP protocol number here (1), which is
not a valid code. Many servers will not respond to echo messages with
codes other than 0.

https://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml#icmp-parameters-codes-8

Updates #9299
Signed-off-by: James Tucker <[email protected]>
James Tucker 2 yıl önce
ebeveyn
işleme
8ab46952d4
1 değiştirilmiş dosya ile 1 ekleme ve 1 silme
  1. 1 1
      net/ping/ping.go

+ 1 - 1
net/ping/ping.go

@@ -303,7 +303,7 @@ func (p *Pinger) Send(ctx context.Context, dest net.Addr, data []byte) (time.Dur
 
 	m := icmp.Message{
 		Type: icmpType,
-		Code: icmpType.Protocol(),
+		Code: 0,
 		Body: &icmp.Echo{
 			ID:   int(p.id),
 			Seq:  int(seq),