Explorar o código

derp/derphttp: only log about a weird upgrade if any was specified

Otherwise random browser requests to /derp cause log spam.

Change-Id: I7bdf991d2106f0323868e651156c788a877a90d5
Signed-off-by: Brad Fitzpatrick <[email protected]>
Brad Fitzpatrick %!s(int64=4) %!d(string=hai) anos
pai
achega
eebe7afad7
Modificáronse 1 ficheiros con 3 adicións e 1 borrados
  1. 3 1
      derp/derphttp/derphttp_server.go

+ 3 - 1
derp/derphttp/derphttp_server.go

@@ -23,7 +23,9 @@ func Handler(s *derp.Server) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		up := strings.ToLower(r.Header.Get("Upgrade"))
 		up := strings.ToLower(r.Header.Get("Upgrade"))
 		if up != "websocket" && up != "derp" {
 		if up != "websocket" && up != "derp" {
-			log.Printf("Weird upgrade: %q", up)
+			if up != "" {
+				log.Printf("Weird upgrade: %q", up)
+			}
 			http.Error(w, "DERP requires connection upgrade", http.StatusUpgradeRequired)
 			http.Error(w, "DERP requires connection upgrade", http.StatusUpgradeRequired)
 			return
 			return
 		}
 		}