Browse Source

Adding issues for all quarantined tests (#27381)

Brennan 5 years ago
parent
commit
584e06fced
26 changed files with 29 additions and 40 deletions
  1. 2 2
      src/Components/test/E2ETest/Tests/BootResourceCachingTest.cs
  2. 1 1
      src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs
  3. 1 1
      src/Components/test/E2ETest/Tests/EventBubblingTest.cs
  4. 1 1
      src/Components/test/E2ETest/Tests/EventTest.cs
  5. 1 1
      src/Components/test/E2ETest/Tests/FormsTest.cs
  6. 1 1
      src/Hosting/test/FunctionalTests/ShutdownTests.cs
  7. 0 1
      src/Hosting/test/FunctionalTests/WebHostBuilderTests.cs
  8. 1 1
      src/ProjectTemplates/BlazorTemplates.Tests/BlazorServerTemplateTest.cs
  9. 1 2
      src/Servers/HttpSys/test/FunctionalTests/Listener/RequestBodyTests.cs
  10. 0 4
      src/Servers/HttpSys/test/FunctionalTests/ResponseCachingTests.cs
  11. 0 1
      src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs
  12. 0 1
      src/Servers/IIS/IIS/test/Common.FunctionalTests/FrebTests.cs
  13. 0 1
      src/Servers/IIS/IIS/test/Common.FunctionalTests/LoggingTests.cs
  14. 0 1
      src/Servers/IIS/IIS/test/Common.FunctionalTests/ShutdownTests.cs
  15. 0 1
      src/Servers/IIS/IIS/test/Common.FunctionalTests/StartupTests.cs
  16. 1 1
      src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs
  17. 6 6
      src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs
  18. 1 1
      src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs
  19. 2 2
      src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TimeoutTests.cs
  20. 1 1
      src/Servers/Kestrel/test/InMemory.FunctionalTests/Http3/Http3StreamTests.cs
  21. 2 2
      src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs
  22. 1 1
      src/Shared/test/SuccessfulTests.cs
  23. 1 1
      src/Testing/src/PublicAPI.Unshipped.txt
  24. 3 3
      src/Testing/src/xunit/QuarantinedTestAttribute.cs
  25. 1 1
      src/Testing/test/AssemblyTestLogTests.cs
  26. 1 1
      src/Testing/test/QuarantinedTestAttributeTest.cs

+ 2 - 2
src/Components/test/E2ETest/Tests/BootResourceCachingTest.cs

@@ -39,7 +39,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
         }
 
         [Fact]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27374")]
         public void CachesResourcesAfterFirstLoad()
         {
             // On the first load, we have to fetch everything
@@ -64,7 +64,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
         }
 
         [Fact]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/20154")]
         public void IncrementallyUpdatesCache()
         {
             // Perform a first load to populate the cache

+ 1 - 1
src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs

@@ -489,7 +489,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
         }
 
         [Fact]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27375")]
         public void CanRenderMarkupBlocks()
         {
             var appElement = Browser.MountTestComponent<MarkupBlockComponent>();

+ 1 - 1
src/Components/test/E2ETest/Tests/EventBubblingTest.cs

@@ -102,7 +102,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
         }
 
         [Theory]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27372")]
         [InlineData("target")]
         [InlineData("intermediate")]
         public void StopPropagation(string whereToStopPropagation)

+ 1 - 1
src/Components/test/E2ETest/Tests/EventTest.cs

@@ -186,7 +186,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/1987")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27397")]
         public void InputEvent_RespondsOnKeystrokes()
         {
             Browser.MountTestComponent<InputEventComponent>();

+ 1 - 1
src/Components/test/E2ETest/Tests/FormsTest.cs

@@ -195,7 +195,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/3615")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27398")]
         public void InputDateInteractsWithEditContext_NonNullableDateTime()
         {
             var appElement = MountTypicalValidationComponent();

+ 1 - 1
src/Hosting/test/FunctionalTests/ShutdownTests.cs

@@ -34,7 +34,7 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests
             await ExecuteShutdownTest(nameof(ShutdownTestRun), "Run");
         }
 
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27371")]
         [ConditionalFact]
         [OSSkipCondition(OperatingSystems.Windows)]
         [OSSkipCondition(OperatingSystems.MacOSX)]

+ 0 - 1
src/Hosting/test/FunctionalTests/WebHostBuilderTests.cs

@@ -21,7 +21,6 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests
                 .WithTfms(Tfm.Default);
 
         [ConditionalTheory]
-        [QuarantinedTest]
         [MemberData(nameof(TestVariants))]
         public async Task InjectedStartup_DefaultApplicationNameIsEntryAssembly(TestVariant variant)
         {

+ 1 - 1
src/ProjectTemplates/BlazorTemplates.Tests/BlazorServerTemplateTest.cs

@@ -88,7 +88,7 @@ namespace Templates.Test
         [Theory]
         [InlineData(true)]
         [InlineData(false)]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27376")]
         public async Task BlazorServerTemplateWorks_IndividualAuth(bool useLocalDB)
         {
             // Additional arguments are needed. See: https://github.com/dotnet/aspnetcore/issues/24278

+ 1 - 2
src/Servers/HttpSys/test/FunctionalTests/Listener/RequestBodyTests.cs

@@ -17,7 +17,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener
     public class RequestBodyTests
     {
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/1826")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27399")]
         public async Task RequestBody_SyncReadDisabledByDefault_WorksWhenEnabled()
         {
             string address;
@@ -142,7 +142,6 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener
         }
 
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2206")]
         public async Task RequestBody_ReadAsyncPartialBodyAndExpiredTimeout_Canceled()
         {
             StaggardContent content = new StaggardContent();

+ 0 - 4
src/Servers/HttpSys/test/FunctionalTests/ResponseCachingTests.cs

@@ -45,7 +45,6 @@ namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests
         }
 
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2135")]
         public async Task Caching_JustPublic_NotCached()
         {
             var requestCount = 1;
@@ -108,7 +107,6 @@ namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests
         }
 
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2207")]
         public async Task Caching_WithoutContentType_Cached_OnWin7AndWin2008R2()
         {
             if (Utilities.IsWin8orLater)
@@ -261,7 +259,6 @@ namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests
         [ConditionalTheory]
         [InlineData("0")]
         [InlineData("-1")]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2208")]
         public async Task Caching_InvalidExpires_NotCached(string expiresValue)
         {
             var requestCount = 1;
@@ -406,7 +403,6 @@ namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests
         }
 
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2209")]
         public async Task Caching_VariousStatusCodes_Cached()
         {
             var requestCount = 1;

+ 0 - 1
src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs

@@ -131,7 +131,6 @@ namespace Microsoft.AspNetCore.Server.HttpSys
         }
 
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2267")]
         public async Task Server_ShutdownDuringRequest_Success()
         {
             Task<string> responseTask;

+ 0 - 1
src/Servers/IIS/IIS/test/Common.FunctionalTests/FrebTests.cs

@@ -84,7 +84,6 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
         // Adding extra logging, marking as flaky, and repeating should help
         [ConditionalFact]
         [MaximumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10_20H1, SkipReason = "Shutdown hangs https://github.com/dotnet/aspnetcore/issues/25107")]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2570")]
         [Repeat(10)]
         [RequiresIIS(IISCapability.FailedRequestTracingModule)]
         public async Task CheckFrebDisconnect()

+ 0 - 1
src/Servers/IIS/IIS/test/Common.FunctionalTests/LoggingTests.cs

@@ -184,7 +184,6 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
         [ConditionalTheory]
         [MaximumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10_20H1, SkipReason = "Shutdown hangs https://github.com/dotnet/aspnetcore/issues/25107")]
         [MemberData(nameof(InprocessTestVariants))]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2200")]
         public async Task CheckUTF8File(TestVariant variant)
         {
             var path = "CheckConsoleFunctions";

+ 0 - 1
src/Servers/IIS/IIS/test/Common.FunctionalTests/ShutdownTests.cs

@@ -417,7 +417,6 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
         }
 
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/1794")]
         public async Task ConfigurationTouchedStress_InProcess()
         {
             await ConfigurationTouchedStress(HostingModel.InProcess);

+ 0 - 1
src/Servers/IIS/IIS/test/Common.FunctionalTests/StartupTests.cs

@@ -122,7 +122,6 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
         [SkipIfNotAdmin]
         [RequiresNewShim]
         [RequiresIIS(IISCapability.PoolEnvironmentVariables)]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2221")]
         public async Task StartsWithDotnetInstallLocation()
         {
             var deploymentParameters = Fixture.GetBaseDeploymentParameters();

+ 1 - 1
src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs

@@ -226,7 +226,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
         }
 
         [ConditionalFact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/1817")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27400")]
         public async Task ReaderThrowsResetExceptionOnInvalidBody()
         {
             var requestStartedCompletionSource = CreateTaskCompletionSource();

+ 6 - 6
src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs

@@ -35,7 +35,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
 
         [ConditionalFact]
         [HostNameIsReachable]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27377")]
         public async Task RegisterAddresses_HostName_Success()
         {
             var hostName = Dns.GetHostName();
@@ -112,7 +112,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
         [ConditionalTheory]
         [MemberData(nameof(IPEndPointRegistrationDataPort443))]
         [IPv6SupportedCondition]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2711")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27401")]
         public async Task RegisterIPEndPoint_Port443_Success(IPEndPoint endpoint, string testUrl)
         {
             if (!CanBindToEndpoint(endpoint.Address, 443))
@@ -135,7 +135,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
         [ConditionalTheory]
         [MemberData(nameof(AddressRegistrationDataIPv6Port5000And5001Default))]
         [IPv6SupportedCondition]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2711")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27401")]
         public async Task RegisterAddresses_IPv6Port5000And5001Default_Success(string addressInput, string[] testUrls)
         {
             if ((!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 5000)) &&
@@ -150,7 +150,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
         [ConditionalTheory]
         [MemberData(nameof(AddressRegistrationDataIPv6Port80))]
         [IPv6SupportedCondition]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2711")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27401")]
         public async Task RegisterAddresses_IPv6Port80_Success(string addressInput, string[] testUrls)
         {
             if (!CanBindToEndpoint(IPAddress.Loopback, 80) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 80))
@@ -162,7 +162,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
         }
 
         [ConditionalTheory]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2179")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27401")]
         [MemberData(nameof(AddressRegistrationDataIPv6ScopeId))]
         [IPv6SupportedCondition]
         [IPv6ScopeIdPresentCondition]
@@ -365,7 +365,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
 
         [ConditionalFact]
         [HostNameIsReachable]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27377")]
         public async Task ListenAnyIP_HostName_Success()
         {
             var hostName = Dns.GetHostName();

+ 1 - 1
src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs

@@ -110,7 +110,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
         }
         [Theory]
         [MemberData(nameof(LargeUploadData))]
-        [QuarantinedTest] // This is inherently flaky and should never be unquarantined.
+        [QuarantinedTest("This is inherently flaky and should never be unquarantined.")]
         public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause)
         {
             // Parameters

+ 2 - 2
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TimeoutTests.cs

@@ -333,7 +333,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/1323")]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/21520")]
         public async Task DATA_Sent_TooSlowlyDueToSocketBackPressureOnSmallWrite_AbortsConnectionAfterGracePeriod()
         {
             var mockSystemClock = _serviceContext.MockSystemClock;
@@ -386,7 +386,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
         }
 
         [Fact]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/21520")]
         public async Task DATA_Sent_TooSlowlyDueToSocketBackPressureOnLargeWrite_AbortsConnectionAfterRateTimeout()
         {
             var mockSystemClock = _serviceContext.MockSystemClock;

+ 1 - 1
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http3/Http3StreamTests.cs

@@ -264,7 +264,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
         }
 
         [Fact]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/21520")]
         public async Task MissingAuthority_200Status()
         {
             var headers = new[]

+ 2 - 2
src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs

@@ -1182,7 +1182,7 @@ namespace Interop.FunctionalTests
         // Nor does Kestrel yet support sending dynamic table updates, so there's nothing to test here. https://github.com/dotnet/aspnetcore/issues/4715
 
         [Theory]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27379")]
         [MemberData(nameof(SupportedSchemes))]
         public async Task Settings_MaxConcurrentStreamsGet_Server(string scheme)
         {
@@ -1244,7 +1244,7 @@ namespace Interop.FunctionalTests
         }
 
         [Theory]
-        [QuarantinedTest]
+        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27370")]
         [MemberData(nameof(SupportedSchemes))]
         public async Task Settings_MaxConcurrentStreamsPost_Server(string scheme)
         {

+ 1 - 1
src/Shared/test/SuccessfulTests.cs

@@ -15,7 +15,7 @@ namespace AlwaysTestTests
         /// Test that executes in quarantined runs and always succeeds.
         /// </summary>
         [Fact]
-        [QuarantinedTest]
+        [QuarantinedTest("No issue")]
         public void GuaranteedQuarantinedTest()
         {
         }

+ 1 - 1
src/Testing/src/PublicAPI.Unshipped.txt

@@ -184,7 +184,7 @@ virtual Microsoft.AspNetCore.Testing.LoggedTestBase.Dispose() -> void
 ~Microsoft.AspNetCore.Testing.OSSkipConditionAttribute.OSSkipConditionAttribute(Microsoft.AspNetCore.Testing.OperatingSystems operatingSystem, params string[] versions) -> void
 ~Microsoft.AspNetCore.Testing.OSSkipConditionAttribute.SkipReason.get -> string
 ~Microsoft.AspNetCore.Testing.OSSkipConditionAttribute.SkipReason.set -> void
-~Microsoft.AspNetCore.Testing.QuarantinedTestAttribute.QuarantinedTestAttribute(string reason = null) -> void
+~Microsoft.AspNetCore.Testing.QuarantinedTestAttribute.QuarantinedTestAttribute(string reason) -> void
 ~Microsoft.AspNetCore.Testing.QuarantinedTestAttribute.Reason.get -> string
 ~Microsoft.AspNetCore.Testing.QuarantinedTestTraitDiscoverer.GetTraits(Xunit.Abstractions.IAttributeInfo traitAttribute) -> System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, string>>
 ~Microsoft.AspNetCore.Testing.ReplaceCultureAttribute.Culture.get -> System.Globalization.CultureInfo

+ 3 - 3
src/Testing/src/xunit/QuarantinedTestAttribute.cs

@@ -19,7 +19,7 @@ namespace Microsoft.AspNetCore.Testing
     /// <example>
     /// <code>
     /// [Fact]
-    /// [QuarantinedTest]
+    /// [QuarantinedTest("Github Url")]
     /// public void FlakyTest()
     /// {
     ///     // Flakiness
@@ -48,8 +48,8 @@ namespace Microsoft.AspNetCore.Testing
         /// <summary>
         /// Initializes a new instance of the <see cref="QuarantinedTestAttribute"/> class with an optional <see cref="Reason"/>.
         /// </summary>
-        /// <param name="reason">A reason that this test is quarantined.</param>
-        public QuarantinedTestAttribute(string reason = null)
+        /// <param name="reason">A reason that this test is quarantined. Preferably a Github issue Url.</param>
+        public QuarantinedTestAttribute(string reason)
         {
             Reason = reason;
         }

+ 1 - 1
src/Testing/test/AssemblyTestLogTests.cs

@@ -27,7 +27,7 @@ namespace Microsoft.Extensions.Logging.Testing.Tests
 
         [Fact]
         // Keep this test in quarantine, it verifies that quarantined test logs are preserved
-        [QuarantinedTest]
+        [QuarantinedTest("No issue")]
         public void FunctionalLogs_LogsPreservedFromQuarantinedTest()
         {
         }

+ 1 - 1
src/Testing/test/QuarantinedTestAttributeTest.cs

@@ -10,7 +10,7 @@ namespace Microsoft.AspNetCore.Testing.Tests
     public class QuarantinedTestAttributeTest
     {
         [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")]
-        [QuarantinedTest]
+        [QuarantinedTest("No issue")]
         public void AlwaysFlakyInCI()
         {
             if (!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("HELIX")) || !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("AGENT_OS")))