Browse Source

Apply suggestions from code review

Pranav K 4 years ago
parent
commit
bc2a226cbb

+ 1 - 1
src/Http/Http.Abstractions/src/HostString.cs

@@ -172,7 +172,7 @@ public readonly struct HostString : IEquatable<HostString>
             {
                 // IPv6 without brackets ::1 is the only type of host with 2 or more colons
             }
-            else if (uriComponent.Contains("xn--"))
+            else if (uriComponent.Contains("xn--", StringComparison.Ordinal))
             {
                 // Contains punycode
                 if (index >= 0)

+ 1 - 1
src/Middleware/Rewrite/src/RewriteRule.cs

@@ -59,7 +59,7 @@ internal class RewriteRule : IRule
                 result = "/";
             }
 
-            if (result.Contains(Uri.SchemeDelimiter))
+            if (result.Contains(Uri.SchemeDelimiter, StringComparison.Ordinal))
             {
                 string scheme;
                 HostString host;

+ 1 - 1
src/Middleware/Rewrite/src/UrlActions/RewriteAction.cs

@@ -59,7 +59,7 @@ internal class RewriteAction : UrlAction
         }
 
         // TODO PERF, substrings, object creation, etc.
-        if (pattern.Contains(Uri.SchemeDelimiter))
+        if (pattern.Contains(Uri.SchemeDelimiter, StringComparison.Ordinal))
         {
             string scheme;
             HostString host;

+ 2 - 2
src/Mvc/Mvc.TagHelpers/src/TagHelperOutputExtensions.cs

@@ -176,7 +176,7 @@ public static class TagHelperOutputExtensions
 
         var encodedSpaceChars = SpaceChars.Where(x => !x.Equals('\u0020')).Select(x => htmlEncoder.Encode(x.ToString())).ToArray();
 
-        if (SpaceChars.Any(classValue.Contains) || encodedSpaceChars.Any(value => classValue.Contains(value)))
+        if (SpaceChars.Any(classValue.Contains) || encodedSpaceChars.Any(value => classValue.Contains(value, StringComparison.Ordinal)))
         {
             throw new ArgumentException(Resources.ArgumentCannotContainHtmlSpace, nameof(classValue));
         }
@@ -233,7 +233,7 @@ public static class TagHelperOutputExtensions
 
         var encodedSpaceChars = SpaceChars.Where(x => !x.Equals('\u0020')).Select(x => htmlEncoder.Encode(x.ToString())).ToArray();
 
-        if (SpaceChars.Any(classValue.Contains) || encodedSpaceChars.Any(value => classValue.Contains(value)))
+        if (SpaceChars.Any(classValue.Contains) || encodedSpaceChars.Any(value => classValue.Contains(value, StringComparison.Ordinal)))
         {
             throw new ArgumentException(Resources.ArgumentCannotContainHtmlSpace, nameof(classValue));
         }