| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861 |
- // Copyright (c) .NET Foundation. All rights reserved.
- // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
- using System;
- using System.IO;
- using System.Text;
- using System.Threading.Tasks;
- using Microsoft.AspNetCore.Http;
- using Microsoft.AspNetCore.Testing;
- using Microsoft.Extensions.Options;
- using Microsoft.Net.Http.Headers;
- using Microsoft.Extensions.Logging;
- using Moq;
- using Xunit;
- namespace Microsoft.AspNetCore.HttpLogging
- {
- public class HttpLoggingMiddlewareTests : LoggedTest
- {
- public static TheoryData BodyData
- {
- get
- {
- var variations = new TheoryData<string>();
- variations.Add("Hello World");
- variations.Add(new string('a', 4097));
- variations.Add(new string('b', 10000));
- variations.Add(new string('あ', 10000));
- return variations;
- }
- }
- [Fact]
- public void Ctor_ThrowsExceptionsWhenNullArgs()
- {
- Assert.Throws<ArgumentNullException>(() => new HttpLoggingMiddleware(
- null,
- CreateOptionsAccessor(),
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>()));
- Assert.Throws<ArgumentNullException>(() => new HttpLoggingMiddleware(c =>
- {
- return Task.CompletedTask;
- },
- null,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>()));
- Assert.Throws<ArgumentNullException>(() => new HttpLoggingMiddleware(c =>
- {
- return Task.CompletedTask;
- },
- CreateOptionsAccessor(),
- null));
- }
- [Fact]
- public async Task NoopWhenLoggingDisabled()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.None;
- var middleware = new HttpLoggingMiddleware(
- c =>
- {
- c.Response.StatusCode = 200;
- return Task.CompletedTask;
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.Protocol = "HTTP/1.0";
- httpContext.Request.Method = "GET";
- httpContext.Request.Scheme = "http";
- httpContext.Request.Path = new PathString("/foo");
- httpContext.Request.PathBase = new PathString("/foo");
- httpContext.Request.QueryString = new QueryString("?foo");
- httpContext.Request.Headers["Connection"] = "keep-alive";
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes("test"));
- await middleware.Invoke(httpContext);
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Protocol: HTTP/1.0"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Method: GET"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Scheme: http"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Path: /foo"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("PathBase: /foo"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("QueryString: ?foo"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Connection: keep-alive"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("StatusCode: 200"));
- }
- [Fact]
- public async Task DefaultRequestInfoOnlyHeadersAndRequestInfo()
- {
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- }
- },
- CreateOptionsAccessor(),
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.Protocol = "HTTP/1.0";
- httpContext.Request.Method = "GET";
- httpContext.Request.Scheme = "http";
- httpContext.Request.Path = new PathString("/foo");
- httpContext.Request.PathBase = new PathString("/foo");
- httpContext.Request.Headers["Connection"] = "keep-alive";
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes("test"));
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Protocol: HTTP/1.0"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Method: GET"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Scheme: http"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Path: /foo"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("PathBase: /foo"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Connection: keep-alive"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task RequestLogsAllRequestInfo()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.Request;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- }
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.Protocol = "HTTP/1.0";
- httpContext.Request.Method = "GET";
- httpContext.Request.Scheme = "http";
- httpContext.Request.Path = new PathString("/foo");
- httpContext.Request.PathBase = new PathString("/foo");
- httpContext.Request.Headers["Connection"] = "keep-alive";
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes("test"));
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Protocol: HTTP/1.0"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Method: GET"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Scheme: http"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Path: /foo"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("PathBase: /foo"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Connection: keep-alive"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task RequestPropertiesLogs()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestProperties;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- }
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.Protocol = "HTTP/1.0";
- httpContext.Request.Method = "GET";
- httpContext.Request.Scheme = "http";
- httpContext.Request.Path = new PathString("/foo");
- httpContext.Request.PathBase = new PathString("/foo");
- httpContext.Request.Headers["Connection"] = "keep-alive";
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes("test"));
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Protocol: HTTP/1.0"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Method: GET"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Scheme: http"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Path: /foo"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("PathBase: /foo"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Connection: keep-alive"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task RequestHeadersLogs()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestHeaders;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- }
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.Protocol = "HTTP/1.0";
- httpContext.Request.Method = "GET";
- httpContext.Request.Scheme = "http";
- httpContext.Request.Path = new PathString("/foo");
- httpContext.Request.PathBase = new PathString("/foo");
- httpContext.Request.QueryString = new QueryString("?foo");
- httpContext.Request.Headers["Connection"] = "keep-alive";
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes("test"));
- await middleware.Invoke(httpContext);
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Protocol: HTTP/1.0"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Method: GET"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Scheme: http"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Path: /foo"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("PathBase: /foo"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("QueryString: ?foo"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Connection: keep-alive"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task UnknownRequestHeadersRedacted()
- {
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- }
- },
- CreateOptionsAccessor(),
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.Headers["foo"] = "bar";
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("foo: [Redacted]"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("foo: bar"));
- }
- [Fact]
- public async Task CanConfigureRequestAllowList()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.RequestHeaders.Clear();
- options.CurrentValue.RequestHeaders.Add("foo");
- var middleware = new HttpLoggingMiddleware(
- c =>
- {
- return Task.CompletedTask;
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- // Header on the default allow list.
- httpContext.Request.Headers["Connection"] = "keep-alive";
- httpContext.Request.Headers["foo"] = "bar";
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("foo: bar"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("foo: [Redacted]"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Connection: [Redacted]"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Connection: keep-alive"));
- }
- [Theory]
- [MemberData(nameof(BodyData))]
- public async Task RequestBodyReadingWorks(string expected)
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestBody;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- }
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes(expected));
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains(expected));
- }
- [Fact]
- public async Task RequestBodyReadingLimitLongCharactersWorks()
- {
- var input = string.Concat(new string('あ', 5));
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestBody;
- options.CurrentValue.RequestBodyLogLimit = 4;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- var count = 0;
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- count += res;
- }
- Assert.Equal(15, count);
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes(input));
- await middleware.Invoke(httpContext);
- var expected = input.Substring(0, options.CurrentValue.RequestBodyLogLimit / 3);
- Assert.Contains(TestSink.Writes, w => w.Message.Equals("RequestBody: " + expected));
- }
- [Fact]
- public async Task RequestBodyReadingLimitWorks()
- {
- var input = string.Concat(new string('a', 60000), new string('b', 3000));
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestBody;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- var count = 0;
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- count += res;
- }
- Assert.Equal(63000, count);
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes(input));
- await middleware.Invoke(httpContext);
- var expected = input.Substring(0, options.CurrentValue.ResponseBodyLogLimit);
- Assert.Contains(TestSink.Writes, w => w.Message.Equals("RequestBody: " + expected));
- }
- [Fact]
- public async Task PartialReadBodyStillLogs()
- {
- var input = string.Concat(new string('a', 60000), new string('b', 3000));
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestBody;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- var res = await c.Request.Body.ReadAsync(arr);
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes(input));
- await middleware.Invoke(httpContext);
- var expected = input.Substring(0, 4096);
- Assert.Contains(TestSink.Writes, w => w.Message.Equals("RequestBody: " + expected));
- }
- [Theory]
- [InlineData("text/plain")]
- [InlineData("text/html")]
- [InlineData("application/json")]
- [InlineData("application/xml")]
- [InlineData("application/entity+json")]
- [InlineData("application/entity+xml")]
- public async Task VerifyDefaultMediaTypeHeaders(string contentType)
- {
- // media headers that should work.
- var expected = new string('a', 1000);
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestBody;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- }
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.ContentType = contentType;
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes(expected));
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains(expected));
- }
- [Theory]
- [InlineData("application/invalid")]
- [InlineData("multipart/form-data")]
- public async Task RejectedContentTypes(string contentType)
- {
- // media headers that should work.
- var expected = new string('a', 1000);
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestBody;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- var count = 0;
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- count += res;
- }
- Assert.Equal(1000, count);
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.ContentType = contentType;
- httpContext.Request.Body = new MemoryStream(Encoding.UTF8.GetBytes(expected));
- await middleware.Invoke(httpContext);
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains(expected));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Unrecognized Content-Type for body."));
- }
- [Fact]
- public async Task DifferentEncodingsWork()
- {
- var encoding = Encoding.Unicode;
- var expected = new string('a', 1000);
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.RequestBody;
- options.CurrentValue.MediaTypeOptions.Clear();
- options.CurrentValue.MediaTypeOptions.AddText("text/plain", encoding);
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- var arr = new byte[4096];
- var count = 0;
- while (true)
- {
- var res = await c.Request.Body.ReadAsync(arr);
- if (res == 0)
- {
- break;
- }
- count += res;
- }
- Assert.Equal(2000, count);
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- httpContext.Request.ContentType = "text/plain";
- httpContext.Request.Body = new MemoryStream(encoding.GetBytes(expected));
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains(expected));
- }
- [Fact]
- public async Task DefaultResponseInfoOnlyHeadersAndRequestInfo()
- {
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- c.Response.StatusCode = 200;
- c.Response.Headers[HeaderNames.TransferEncoding] = "test";
- c.Response.ContentType = "text/plain";
- await c.Response.WriteAsync("test");
- },
- CreateOptionsAccessor(),
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("StatusCode: 200"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Transfer-Encoding: test"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task ResponseInfoLogsAll()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.Response;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- c.Response.StatusCode = 200;
- c.Response.Headers[HeaderNames.TransferEncoding] = "test";
- c.Response.ContentType = "text/plain";
- await c.Response.WriteAsync("test");
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("StatusCode: 200"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Transfer-Encoding: test"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task StatusCodeLogs()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.ResponseStatusCode;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- c.Response.StatusCode = 200;
- c.Response.Headers["Server"] = "Kestrel";
- c.Response.ContentType = "text/plain";
- await c.Response.WriteAsync("test");
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("StatusCode: 200"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Server: Kestrel"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task ResponseHeadersLogs()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.ResponseHeaders;
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- c.Response.StatusCode = 200;
- c.Response.Headers[HeaderNames.TransferEncoding] = "test";
- c.Response.ContentType = "text/plain";
- await c.Response.WriteAsync("test");
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("StatusCode: 200"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Transfer-Encoding: test"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task ResponseHeadersRedacted()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.ResponseHeaders;
- var middleware = new HttpLoggingMiddleware(
- c =>
- {
- c.Response.Headers["Test"] = "Kestrel";
- return Task.CompletedTask;
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Test: [Redacted]"));
- }
- [Fact]
- public async Task AllowedResponseHeadersModify()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.ResponseHeaders;
- options.CurrentValue.ResponseHeaders.Clear();
- options.CurrentValue.ResponseHeaders.Add("Test");
- var middleware = new HttpLoggingMiddleware(
- c =>
- {
- c.Response.Headers["Test"] = "Kestrel";
- c.Response.Headers["Server"] = "Kestrel";
- return Task.CompletedTask;
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Test: Kestrel"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Server: [Redacted]"));
- }
- [Theory]
- [MemberData(nameof(BodyData))]
- public async Task ResponseBodyWritingWorks(string expected)
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.ResponseBody;
- var middleware = new HttpLoggingMiddleware(
- c =>
- {
- c.Response.ContentType = "text/plain";
- return c.Response.WriteAsync(expected);
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains(expected));
- }
- [Fact]
- public async Task ResponseBodyWritingLimitWorks()
- {
- var input = string.Concat(new string('a', 30000), new string('b', 3000));
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.ResponseBody;
- var middleware = new HttpLoggingMiddleware(
- c =>
- {
- c.Response.ContentType = "text/plain";
- return c.Response.WriteAsync(input);
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- var expected = input.Substring(0, options.CurrentValue.ResponseBodyLogLimit);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains(expected));
- }
- [Fact]
- public async Task FirstWriteResponseHeadersLogged()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.Response;
- var writtenHeaders = new TaskCompletionSource<object>();
- var letBodyFinish = new TaskCompletionSource<object>();
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- c.Response.StatusCode = 200;
- c.Response.Headers[HeaderNames.TransferEncoding] = "test";
- c.Response.ContentType = "text/plain";
- await c.Response.WriteAsync("test");
- writtenHeaders.SetResult(null);
- await letBodyFinish.Task;
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- var middlewareTask = middleware.Invoke(httpContext);
- await writtenHeaders.Task;
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("StatusCode: 200"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Transfer-Encoding: test"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- letBodyFinish.SetResult(null);
- await middlewareTask;
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Body: test"));
- }
- [Fact]
- public async Task StartAsyncResponseHeadersLogged()
- {
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.Response;
- var writtenHeaders = new TaskCompletionSource<object>();
- var letBodyFinish = new TaskCompletionSource<object>();
- var middleware = new HttpLoggingMiddleware(
- async c =>
- {
- c.Response.StatusCode = 200;
- c.Response.Headers[HeaderNames.TransferEncoding] = "test";
- c.Response.ContentType = "text/plain";
- await c.Response.StartAsync();
- writtenHeaders.SetResult(null);
- await letBodyFinish.Task;
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- var middlewareTask = middleware.Invoke(httpContext);
- await writtenHeaders.Task;
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("StatusCode: 200"));
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Transfer-Encoding: test"));
- Assert.DoesNotContain(TestSink.Writes, w => w.Message.Contains("Body: test"));
- letBodyFinish.SetResult(null);
- await middlewareTask;
- }
- [Fact]
- public async Task UnrecognizedMediaType()
- {
- var expected = "Hello world";
- var options = CreateOptionsAccessor();
- options.CurrentValue.LoggingFields = HttpLoggingFields.ResponseBody;
- var middleware = new HttpLoggingMiddleware(
- c =>
- {
- c.Response.ContentType = "foo/*";
- return c.Response.WriteAsync(expected);
- },
- options,
- LoggerFactory.CreateLogger<HttpLoggingMiddleware>());
- var httpContext = new DefaultHttpContext();
- await middleware.Invoke(httpContext);
- Assert.Contains(TestSink.Writes, w => w.Message.Contains("Unrecognized Content-Type for body."));
- }
- private IOptionsMonitor<HttpLoggingOptions> CreateOptionsAccessor()
- {
- var options = new HttpLoggingOptions();
- var optionsAccessor = Mock.Of<IOptionsMonitor<HttpLoggingOptions>>(o => o.CurrentValue == options);
- return optionsAccessor;
- }
- }
- }
|