SelectingItemsControlTests_Multiple.cs 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590
  1. // Copyright (c) The Avalonia Project. All rights reserved.
  2. // Licensed under the MIT license. See licence.md file in the project root for full license information.
  3. using System;
  4. using System.Collections;
  5. using System.Collections.Generic;
  6. using System.Linq;
  7. using Avalonia.Collections;
  8. using Avalonia.Controls.Presenters;
  9. using Avalonia.Controls.Primitives;
  10. using Avalonia.Controls.Templates;
  11. using Avalonia.Data;
  12. using Avalonia.Markup.Xaml.Data;
  13. using Xunit;
  14. namespace Avalonia.Controls.UnitTests.Primitives
  15. {
  16. public class SelectingItemsControlTests_Multiple
  17. {
  18. [Fact]
  19. public void Setting_SelectedIndex_Should_Add_To_SelectedItems()
  20. {
  21. var target = new TestSelector
  22. {
  23. Items = new[] { "foo", "bar" },
  24. Template = Template(),
  25. };
  26. target.ApplyTemplate();
  27. target.SelectedIndex = 1;
  28. Assert.Equal(new[] { "bar" }, target.SelectedItems.Cast<object>().ToList());
  29. }
  30. [Fact]
  31. public void Adding_SelectedItems_Should_Set_SelectedIndex()
  32. {
  33. var target = new TestSelector
  34. {
  35. Items = new[] { "foo", "bar" },
  36. Template = Template(),
  37. };
  38. target.ApplyTemplate();
  39. target.SelectedItems.Add("bar");
  40. Assert.Equal(1, target.SelectedIndex);
  41. }
  42. [Fact]
  43. public void Assigning_SelectedItems_Should_Set_SelectedIndex()
  44. {
  45. var target = new TestSelector
  46. {
  47. Items = new[] { "foo", "bar" },
  48. Template = Template(),
  49. };
  50. target.ApplyTemplate();
  51. target.SelectedItems = new AvaloniaList<object>("bar");
  52. Assert.Equal(1, target.SelectedIndex);
  53. }
  54. [Fact]
  55. public void Reassigning_SelectedItems_Should_Clear_Selection()
  56. {
  57. var target = new TestSelector
  58. {
  59. Items = new[] { "foo", "bar" },
  60. Template = Template(),
  61. };
  62. target.ApplyTemplate();
  63. target.SelectedItems.Add("bar");
  64. target.SelectedItems = new AvaloniaList<object>();
  65. Assert.Equal(-1, target.SelectedIndex);
  66. Assert.Equal(null, target.SelectedItem);
  67. }
  68. [Fact]
  69. public void Adding_First_SelectedItem_Should_Raise_SelectedIndex_SelectedItem_Changed()
  70. {
  71. var target = new TestSelector
  72. {
  73. Items = new[] { "foo", "bar" },
  74. Template = Template(),
  75. };
  76. bool indexRaised = false;
  77. bool itemRaised = false;
  78. target.PropertyChanged += (s, e) =>
  79. {
  80. indexRaised |= e.Property.Name == "SelectedIndex" &&
  81. (int)e.OldValue == -1 &&
  82. (int)e.NewValue == 1;
  83. itemRaised |= e.Property.Name == "SelectedItem" &&
  84. (string)e.OldValue == null &&
  85. (string)e.NewValue == "bar";
  86. };
  87. target.ApplyTemplate();
  88. target.SelectedItems.Add("bar");
  89. Assert.True(indexRaised);
  90. Assert.True(itemRaised);
  91. }
  92. [Fact]
  93. public void Adding_Subsequent_SelectedItems_Should_Not_Raise_SelectedIndex_SelectedItem_Changed()
  94. {
  95. var target = new TestSelector
  96. {
  97. Items = new[] { "foo", "bar" },
  98. Template = Template(),
  99. };
  100. target.ApplyTemplate();
  101. target.SelectedItems.Add("foo");
  102. bool raised = false;
  103. target.PropertyChanged += (s, e) =>
  104. raised |= e.Property.Name == "SelectedIndex" ||
  105. e.Property.Name == "SelectedItem";
  106. target.SelectedItems.Add("bar");
  107. Assert.False(raised);
  108. }
  109. [Fact]
  110. public void Removing_Last_SelectedItem_Should_Raise_SelectedIndex_Changed()
  111. {
  112. var target = new TestSelector
  113. {
  114. Items = new[] { "foo", "bar" },
  115. Template = Template(),
  116. };
  117. target.ApplyTemplate();
  118. target.SelectedItems.Add("foo");
  119. bool raised = false;
  120. target.PropertyChanged += (s, e) =>
  121. raised |= e.Property.Name == "SelectedIndex" &&
  122. (int)e.OldValue == 0 &&
  123. (int)e.NewValue == -1;
  124. target.SelectedItems.RemoveAt(0);
  125. Assert.True(raised);
  126. }
  127. [Fact]
  128. public void Adding_SelectedItems_Should_Set_Item_IsSelected()
  129. {
  130. var items = new[]
  131. {
  132. new ListBoxItem(),
  133. new ListBoxItem(),
  134. new ListBoxItem(),
  135. };
  136. var target = new TestSelector
  137. {
  138. Items = items,
  139. Template = Template(),
  140. };
  141. target.ApplyTemplate();
  142. target.Presenter.ApplyTemplate();
  143. target.SelectedItems.Add(items[0]);
  144. target.SelectedItems.Add(items[1]);
  145. var foo = target.Presenter.Panel.Children[0];
  146. Assert.True(items[0].IsSelected);
  147. Assert.True(items[1].IsSelected);
  148. Assert.False(items[2].IsSelected);
  149. }
  150. [Fact]
  151. public void Assigning_SelectedItems_Should_Set_Item_IsSelected()
  152. {
  153. var items = new[]
  154. {
  155. new ListBoxItem(),
  156. new ListBoxItem(),
  157. new ListBoxItem(),
  158. };
  159. var target = new TestSelector
  160. {
  161. Items = items,
  162. Template = Template(),
  163. };
  164. target.ApplyTemplate();
  165. target.Presenter.ApplyTemplate();
  166. target.SelectedItems = new AvaloniaList<object> { items[0], items[1] };
  167. Assert.True(items[0].IsSelected);
  168. Assert.True(items[1].IsSelected);
  169. Assert.False(items[2].IsSelected);
  170. }
  171. [Fact]
  172. public void Removing_SelectedItems_Should_Clear_Item_IsSelected()
  173. {
  174. var items = new[]
  175. {
  176. new ListBoxItem(),
  177. new ListBoxItem(),
  178. new ListBoxItem(),
  179. };
  180. var target = new TestSelector
  181. {
  182. Items = items,
  183. Template = Template(),
  184. };
  185. target.ApplyTemplate();
  186. target.Presenter.ApplyTemplate();
  187. target.SelectedItems.Add(items[0]);
  188. target.SelectedItems.Add(items[1]);
  189. target.SelectedItems.Remove(items[1]);
  190. Assert.True(items[0].IsSelected);
  191. Assert.False(items[1].IsSelected);
  192. }
  193. [Fact]
  194. public void Reassigning_SelectedItems_Should_Clear_Item_IsSelected()
  195. {
  196. var items = new[]
  197. {
  198. new ListBoxItem(),
  199. new ListBoxItem(),
  200. new ListBoxItem(),
  201. };
  202. var target = new TestSelector
  203. {
  204. Items = items,
  205. Template = Template(),
  206. };
  207. target.ApplyTemplate();
  208. target.SelectedItems.Add(items[0]);
  209. target.SelectedItems.Add(items[1]);
  210. target.SelectedItems = new AvaloniaList<object> { items[0], items[1] };
  211. Assert.False(items[0].IsSelected);
  212. Assert.False(items[1].IsSelected);
  213. }
  214. [Fact]
  215. public void Replacing_First_SelectedItem_Should_Update_SelectedItem_SelectedIndex()
  216. {
  217. var items = new[]
  218. {
  219. new ListBoxItem(),
  220. new ListBoxItem(),
  221. new ListBoxItem(),
  222. };
  223. var target = new TestSelector
  224. {
  225. Items = items,
  226. Template = Template(),
  227. };
  228. target.ApplyTemplate();
  229. target.Presenter.ApplyTemplate();
  230. target.SelectedIndex = 1;
  231. target.SelectedItems[0] = items[2];
  232. Assert.Equal(2, target.SelectedIndex);
  233. Assert.Equal(items[2], target.SelectedItem);
  234. Assert.False(items[0].IsSelected);
  235. Assert.False(items[1].IsSelected);
  236. Assert.True(items[2].IsSelected);
  237. }
  238. [Fact]
  239. public void Range_Select_Should_Select_Range()
  240. {
  241. var target = new TestSelector
  242. {
  243. Items = new[]
  244. {
  245. "foo",
  246. "bar",
  247. "baz",
  248. "qux",
  249. "qiz",
  250. "lol",
  251. },
  252. SelectionMode = SelectionMode.Multiple,
  253. Template = Template(),
  254. };
  255. target.ApplyTemplate();
  256. target.SelectedIndex = 1;
  257. target.SelectRange(3);
  258. Assert.Equal(new[] { "bar", "baz", "qux" }, target.SelectedItems.Cast<object>().ToList());
  259. }
  260. [Fact]
  261. public void Range_Select_Backwards_Should_Select_Range()
  262. {
  263. var target = new TestSelector
  264. {
  265. Items = new[]
  266. {
  267. "foo",
  268. "bar",
  269. "baz",
  270. "qux",
  271. "qiz",
  272. "lol",
  273. },
  274. SelectionMode = SelectionMode.Multiple,
  275. Template = Template(),
  276. };
  277. target.ApplyTemplate();
  278. target.SelectedIndex = 3;
  279. target.SelectRange(1);
  280. Assert.Equal(new[] { "qux", "baz", "bar" }, target.SelectedItems.Cast<object>().ToList());
  281. }
  282. [Fact]
  283. public void Second_Range_Select_Backwards_Should_Select_From_Original_Selection()
  284. {
  285. var target = new TestSelector
  286. {
  287. Items = new[]
  288. {
  289. "foo",
  290. "bar",
  291. "baz",
  292. "qux",
  293. "qiz",
  294. "lol",
  295. },
  296. SelectionMode = SelectionMode.Multiple,
  297. Template = Template(),
  298. };
  299. target.ApplyTemplate();
  300. target.SelectedIndex = 2;
  301. target.SelectRange(5);
  302. target.SelectRange(4);
  303. Assert.Equal(new[] { "baz", "qux", "qiz" }, target.SelectedItems.Cast<object>().ToList());
  304. }
  305. [Fact]
  306. public void Suprious_SelectedIndex_Changes_Should_Not_Be_Triggered()
  307. {
  308. var target = new TestSelector
  309. {
  310. Items = new[] { "foo", "bar", "baz" },
  311. Template = Template(),
  312. };
  313. target.ApplyTemplate();
  314. var selectedIndexes = new List<int>();
  315. target.GetObservable(TestSelector.SelectedIndexProperty).Subscribe(x => selectedIndexes.Add(x));
  316. target.SelectedItems = new AvaloniaList<object> { "bar", "baz" };
  317. target.SelectedItem = "foo";
  318. Assert.Equal(0, target.SelectedIndex);
  319. Assert.Equal(new[] { -1, 1, 0 }, selectedIndexes);
  320. }
  321. /// <summary>
  322. /// Tests a problem discovered with ListBox with selection.
  323. /// </summary>
  324. /// <remarks>
  325. /// - Items is bound to DataContext first, followed by say SelectedIndex
  326. /// - When the ListBox is removed from the visual tree, DataContext becomes null (as it's
  327. /// inherited)
  328. /// - This changes Items to null, which changes SelectedIndex to null as there are no
  329. /// longer any items
  330. /// - However, the news that DataContext is now null hasn't yet reached the SelectedItems
  331. /// binding and so the unselection is sent back to the ViewModel
  332. ///
  333. /// This is a similar problem to that tested by XamlBindingTest.Should_Not_Write_To_Old_DataContext.
  334. /// However, that tests a general property binding problem: here we are writing directly
  335. /// to the SelectedItems collection - not via a binding - so it's something that the
  336. /// binding system cannot solve. Instead we solve it by not clearing SelectedItems when
  337. /// DataContext is in the process of changing.
  338. /// </remarks>
  339. [Fact]
  340. public void Should_Not_Write_To_Old_DataContext()
  341. {
  342. var vm = new OldDataContextViewModel();
  343. var target = new TestSelector();
  344. var itemsBinding = new Binding
  345. {
  346. Path = "Items",
  347. Mode = BindingMode.OneWay,
  348. };
  349. var selectedItemsBinding = new Binding
  350. {
  351. Path = "SelectedItems",
  352. Mode = BindingMode.OneWay,
  353. };
  354. // Bind Items and SelectedItems to the VM.
  355. target.Bind(TestSelector.ItemsProperty, itemsBinding);
  356. target.Bind(TestSelector.SelectedItemsProperty, selectedItemsBinding);
  357. // Set DataContext and SelectedIndex
  358. target.DataContext = vm;
  359. target.SelectedIndex = 1;
  360. // Make sure SelectedItems are written back to VM.
  361. Assert.Equal(new[] { "bar" }, vm.SelectedItems);
  362. // Clear DataContext and ensure that SelectedItems is still set in the VM.
  363. target.DataContext = null;
  364. Assert.Equal(new[] { "bar" }, vm.SelectedItems);
  365. // Ensure target's SelectedItems is now clear.
  366. Assert.Empty(target.SelectedItems);
  367. }
  368. [Fact]
  369. public void Unbound_SelectedItems_Should_Be_Cleared_When_DataContext_Cleared()
  370. {
  371. var data = new
  372. {
  373. Items = new[] { "foo", "bar", "baz" },
  374. };
  375. var target = new TestSelector
  376. {
  377. DataContext = data,
  378. Template = Template(),
  379. };
  380. var itemsBinding = new Binding { Path = "Items" };
  381. target.Bind(TestSelector.ItemsProperty, itemsBinding);
  382. Assert.Same(data.Items, target.Items);
  383. target.SelectedItems.Add("bar");
  384. target.DataContext = null;
  385. Assert.Empty(target.SelectedItems);
  386. }
  387. [Fact]
  388. public void Adding_To_SelectedItems_Should_Raise_SelectionChanged()
  389. {
  390. var items = new[] { "foo", "bar", "baz" };
  391. var target = new TestSelector
  392. {
  393. DataContext = items,
  394. Template = Template(),
  395. };
  396. var called = false;
  397. target.SelectionChanged += (s, e) =>
  398. {
  399. Assert.Equal(new[] { "bar" }, e.AddedItems.Cast<object>().ToList());
  400. Assert.Empty(e.RemovedItems);
  401. called = true;
  402. };
  403. target.SelectedItems.Add("bar");
  404. Assert.True(called);
  405. }
  406. [Fact]
  407. public void Removing_From_SelectedItems_Should_Raise_SelectionChanged()
  408. {
  409. var items = new[] { "foo", "bar", "baz" };
  410. var target = new TestSelector
  411. {
  412. Items = items,
  413. Template = Template(),
  414. SelectedItem = "bar",
  415. };
  416. var called = false;
  417. target.SelectionChanged += (s, e) =>
  418. {
  419. Assert.Equal(new[] { "bar" }, e.RemovedItems.Cast<object>().ToList());
  420. Assert.Empty(e.AddedItems);
  421. called = true;
  422. };
  423. target.SelectedItems.Remove("bar");
  424. Assert.True(called);
  425. }
  426. [Fact]
  427. public void Assigning_SelectedItems_Should_Raise_SelectionChanged()
  428. {
  429. var items = new[] { "foo", "bar", "baz" };
  430. var target = new TestSelector
  431. {
  432. Items = items,
  433. Template = Template(),
  434. SelectedItem = "bar",
  435. };
  436. var called = false;
  437. target.SelectionChanged += (s, e) =>
  438. {
  439. Assert.Equal(new[] { "foo", "baz" }, e.AddedItems.Cast<object>());
  440. Assert.Equal(new[] { "bar" }, e.RemovedItems.Cast<object>());
  441. called = true;
  442. };
  443. target.ApplyTemplate();
  444. target.Presenter.ApplyTemplate();
  445. target.SelectedItems = new AvaloniaList<object>("foo", "baz");
  446. Assert.True(called);
  447. }
  448. private FuncControlTemplate Template()
  449. {
  450. return new FuncControlTemplate<SelectingItemsControl>(control =>
  451. new ItemsPresenter
  452. {
  453. Name = "PART_ItemsPresenter",
  454. [~ItemsPresenter.ItemsProperty] = control[~ItemsControl.ItemsProperty],
  455. [~ItemsPresenter.ItemsPanelProperty] = control[~ItemsControl.ItemsPanelProperty],
  456. });
  457. }
  458. private class TestSelector : SelectingItemsControl
  459. {
  460. public static readonly new AvaloniaProperty<IList> SelectedItemsProperty =
  461. SelectingItemsControl.SelectedItemsProperty;
  462. public new IList SelectedItems
  463. {
  464. get { return base.SelectedItems; }
  465. set { base.SelectedItems = value; }
  466. }
  467. public new SelectionMode SelectionMode
  468. {
  469. get { return base.SelectionMode; }
  470. set { base.SelectionMode = value; }
  471. }
  472. public void SelectRange(int index)
  473. {
  474. UpdateSelection(index, true, true);
  475. }
  476. }
  477. private class OldDataContextViewModel
  478. {
  479. public OldDataContextViewModel()
  480. {
  481. Items = new List<string> { "foo", "bar" };
  482. SelectedItems = new List<string>();
  483. }
  484. public List<string> Items { get; }
  485. public List<string> SelectedItems { get; }
  486. }
  487. }
  488. }