Browse Source

Fix file() command descriptor leak on error

Credit goes to "cppcheck".

Signed-off-by: Thomas Jarosch <[email protected]>
Thomas Jarosch 14 years ago
parent
commit
4868921bc2
1 changed files with 2 additions and 0 deletions
  1. 2 0
      Source/cmFileCommand.cxx

+ 2 - 0
Source/cmFileCommand.cxx

@@ -2982,6 +2982,7 @@ cmFileCommand::HandleUploadCommand(std::vector<std::string> const& args)
     std::string errStr = "UPLOAD cannot stat file '";
     errStr += filename + "'.";
     this->SetError(errStr.c_str());
+    fclose(fin);
     return false;
     }
 
@@ -2991,6 +2992,7 @@ cmFileCommand::HandleUploadCommand(std::vector<std::string> const& args)
   if(!curl)
     {
     this->SetError("UPLOAD error initializing curl.");
+    fclose(fin);
     return false;
     }