浏览代码

Only fail after chmod error if permissions differ (e.g. on config file) (#8771)

Andreas Sommer 2 年之前
父节点
当前提交
2f88dafa56
共有 1 个文件被更改,包括 8 次插入2 次删除
  1. 8 2
      lib/osutil/atomic.go

+ 8 - 2
lib/osutil/atomic.go

@@ -109,9 +109,15 @@ func (w *AtomicWriter) Close() error {
 		return err
 	}
 	if infoErr == nil {
+		// Restore chmod setting for final file to what it was
 		if err := w.fs.Chmod(w.path, info.Mode()); err != nil {
-			w.err = err
-			return err
+			// Only fail if permissions differ, since some filesystems are expected to not allow chmod (e.g. error
+			// `operation not permitted`).
+			infoAfterRename, infoAfterRenameErr := w.fs.Lstat(w.path)
+			if infoAfterRenameErr != nil || infoAfterRename.Mode() != info.Mode() {
+				w.err = err
+				return err
+			}
 		}
 	}