浏览代码

Remove redundant method - code review suggestion

Dydzio 2 年之前
父节点
当前提交
68be7643f1
共有 3 个文件被更改,包括 1 次插入17 次删除
  1. 1 1
      client/battle/BattleStacksController.cpp
  2. 0 15
      lib/battle/CBattleInfoEssentials.cpp
  3. 0 1
      lib/battle/CBattleInfoEssentials.h

+ 1 - 1
client/battle/BattleStacksController.cpp

@@ -900,7 +900,7 @@ std::vector<const CStack *> BattleStacksController::selectHoveredStacks()
 	auto hoveredQueueUnitId = owner.windowObject->getQueueHoveredUnitId();
 	if(hoveredQueueUnitId.is_initialized())
 	{
-		return { owner.curInt->cb->battleGetStackByUnitId(hoveredQueueUnitId.value(), true) };
+		return { owner.curInt->cb->battleGetStackByID(hoveredQueueUnitId.value(), true) };
 	}
 
 	auto hoveredHex = owner.fieldController->getHoveredHex();

+ 0 - 15
lib/battle/CBattleInfoEssentials.cpp

@@ -185,21 +185,6 @@ const CStack* CBattleInfoEssentials::battleGetStackByID(int ID, bool onlyAlive)
 		return stacks[0];
 }
 
-const CStack* CBattleInfoEssentials::battleGetStackByUnitId(int unitId, bool onlyAlive) const
-{
-	RETURN_IF_NOT_BATTLE(nullptr);
-
-	auto stacks = battleGetStacksIf([=](const CStack * s)
-	{
-		return s->unitId() == unitId && (!onlyAlive || s->alive());
-	});
-
-	if(stacks.empty())
-		return nullptr;
-	else
-		return stacks[0];
-}
-
 bool CBattleInfoEssentials::battleDoWeKnowAbout(ui8 side) const
 {
 	RETURN_IF_NOT_BATTLE(false);

+ 0 - 1
lib/battle/CBattleInfoEssentials.h

@@ -102,7 +102,6 @@ public:
 	TStacks battleGetAllStacks(bool includeTurrets = false) const;
 
 	const CStack * battleGetStackByID(int ID, bool onlyAlive = true) const; //returns stack info by given ID
-	const CStack * battleGetStackByUnitId(int unitId, bool onlyAlive = true) const; //returns stack info by given ID
 	bool battleIsObstacleVisibleForSide(const CObstacleInstance & coi, BattlePerspective::BattlePerspective side) const;
 
 	///returns player that controls given stack; mind control included