|
|
@@ -1,32 +1,32 @@
|
|
|
-From d6b484b5cb2a7d509b36a220911509ddd8b777c4 Mon Sep 17 00:00:00 2001
|
|
|
-From: Azeem Shaikh <[email protected]>
|
|
|
-Date: Mon, 3 Jul 2023 18:12:56 +0000
|
|
|
-Subject: wifi: mt76: Replace strlcpy() with strscpy()
|
|
|
-
|
|
|
-strlcpy() reads the entire source buffer first.
|
|
|
-This read may exceed the destination size limit.
|
|
|
-This is both inefficient and can lead to linear read
|
|
|
-overflows if a source string is not NUL-terminated [1].
|
|
|
-In an effort to remove strlcpy() completely [2], replace
|
|
|
-strlcpy() here with strscpy().
|
|
|
-
|
|
|
-Direct replacement is safe here since DEV_ASSIGN is only used by
|
|
|
-TRACE macros and the return values are ignored.
|
|
|
-
|
|
|
-[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
|
|
|
-[2] https://github.com/KSPP/linux/issues/89
|
|
|
-
|
|
|
-Signed-off-by: Azeem Shaikh <[email protected]>
|
|
|
-Reviewed-by: Kees Cook <[email protected]>
|
|
|
-Signed-off-by: Kalle Valo <[email protected]>
|
|
|
-Link: https://lore.kernel.org/r/[email protected]
|
|
|
----
|
|
|
- mt7615/mt7615_trace.h | 2 +-
|
|
|
- mt76x02_trace.h | 2 +-
|
|
|
- trace.h | 2 +-
|
|
|
- usb_trace.h | 2 +-
|
|
|
- 4 files changed, 4 insertions(+), 4 deletions(-)
|
|
|
-
|
|
|
+From d6b484b5cb2a7d509b36a220911509ddd8b777c4 Mon Sep 17 00:00:00 2001
|
|
|
+From: Azeem Shaikh <[email protected]>
|
|
|
+Date: Mon, 3 Jul 2023 18:12:56 +0000
|
|
|
+Subject: wifi: mt76: Replace strlcpy() with strscpy()
|
|
|
+
|
|
|
+strlcpy() reads the entire source buffer first.
|
|
|
+This read may exceed the destination size limit.
|
|
|
+This is both inefficient and can lead to linear read
|
|
|
+overflows if a source string is not NUL-terminated [1].
|
|
|
+In an effort to remove strlcpy() completely [2], replace
|
|
|
+strlcpy() here with strscpy().
|
|
|
+
|
|
|
+Direct replacement is safe here since DEV_ASSIGN is only used by
|
|
|
+TRACE macros and the return values are ignored.
|
|
|
+
|
|
|
+[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
|
|
|
+[2] https://github.com/KSPP/linux/issues/89
|
|
|
+
|
|
|
+Signed-off-by: Azeem Shaikh <[email protected]>
|
|
|
+Reviewed-by: Kees Cook <[email protected]>
|
|
|
+Signed-off-by: Kalle Valo <[email protected]>
|
|
|
+Link: https://lore.kernel.org/r/[email protected]
|
|
|
+---
|
|
|
+ mt7615/mt7615_trace.h | 2 +-
|
|
|
+ mt76x02_trace.h | 2 +-
|
|
|
+ trace.h | 2 +-
|
|
|
+ usb_trace.h | 2 +-
|
|
|
+ 4 files changed, 4 insertions(+), 4 deletions(-)
|
|
|
+
|
|
|
--- a/mt7615/mt7615_trace.h
|
|
|
+++ b/mt7615/mt7615_trace.h
|
|
|
@@ -14,7 +14,7 @@
|