1234567891011121314151617181920212223242526272829303132333435363738 |
- From 4774ad841bef97cc51df90195338c5b2573dd4cb Mon Sep 17 00:00:00 2001
- From: Christian Marangi <[email protected]>
- Date: Sun, 23 Apr 2023 19:28:00 +0200
- Subject: [PATCH] net: phy: marvell: Fix inconsistent indenting in
- led_blink_set
- Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
- test robot, probably done by the presence of an if condition dropped in
- later revision of the same code.
- Reported-by: kernel test robot <[email protected]>
- Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
- Fixes: ea9e86485dec ("net: phy: marvell: Implement led_blink_set()")
- Signed-off-by: Christian Marangi <[email protected]>
- Reviewed-by: Andrew Lunn <[email protected]>
- Link: https://lore.kernel.org/r/[email protected]
- Signed-off-by: Jakub Kicinski <[email protected]>
- ---
- drivers/net/phy/marvell.c | 8 ++++----
- 1 file changed, 4 insertions(+), 4 deletions(-)
- --- a/drivers/net/phy/marvell.c
- +++ b/drivers/net/phy/marvell.c
- @@ -2841,10 +2841,10 @@ static int m88e1318_led_blink_set(struct
- case 1:
- case 2:
- reg &= ~(0xf << (4 * index));
- - reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
- - /* Reset default is 84ms */
- - *delay_on = 84 / 2;
- - *delay_off = 84 / 2;
- + reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
- + /* Reset default is 84ms */
- + *delay_on = 84 / 2;
- + *delay_off = 84 / 2;
- break;
- default:
- return -EINVAL;
|