816-v6.4-net-phy-marvell-Fix-inconsistent-indenting-in-led_bl.patch 1.4 KB

1234567891011121314151617181920212223242526272829303132333435363738
  1. From 4774ad841bef97cc51df90195338c5b2573dd4cb Mon Sep 17 00:00:00 2001
  2. From: Christian Marangi <[email protected]>
  3. Date: Sun, 23 Apr 2023 19:28:00 +0200
  4. Subject: [PATCH] net: phy: marvell: Fix inconsistent indenting in
  5. led_blink_set
  6. Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
  7. test robot, probably done by the presence of an if condition dropped in
  8. later revision of the same code.
  9. Reported-by: kernel test robot <[email protected]>
  10. Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
  11. Fixes: ea9e86485dec ("net: phy: marvell: Implement led_blink_set()")
  12. Signed-off-by: Christian Marangi <[email protected]>
  13. Reviewed-by: Andrew Lunn <[email protected]>
  14. Link: https://lore.kernel.org/r/[email protected]
  15. Signed-off-by: Jakub Kicinski <[email protected]>
  16. ---
  17. drivers/net/phy/marvell.c | 8 ++++----
  18. 1 file changed, 4 insertions(+), 4 deletions(-)
  19. --- a/drivers/net/phy/marvell.c
  20. +++ b/drivers/net/phy/marvell.c
  21. @@ -2841,10 +2841,10 @@ static int m88e1318_led_blink_set(struct
  22. case 1:
  23. case 2:
  24. reg &= ~(0xf << (4 * index));
  25. - reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
  26. - /* Reset default is 84ms */
  27. - *delay_on = 84 / 2;
  28. - *delay_off = 84 / 2;
  29. + reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
  30. + /* Reset default is 84ms */
  31. + *delay_on = 84 / 2;
  32. + *delay_off = 84 / 2;
  33. break;
  34. default:
  35. return -EINVAL;